Introduce hermes-prelude as a proxy crate for cgp::prelude#600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new
hermes-preludecrate that acts as a proxy and re-exportscgp::prelude.This is mainly in anticipation of potential breaking changes in
cgpwhen return type notation is getting stabilized in rust-lang/rust#138424. When that happens, there would be no longer need forcgpto export theAsyncand#[async_trait]helpers to define async types and methods in CGP.To help the migration, the
hermes-preludecrate would continue to exportAsyncand#[async_trait], even after they are removed fromcgp. This will help ensure that most of the Hermes code base will remain working without requiring significant breaking changes.