Skip to content

feat(inputs.net): Add speed metric#14625

Merged
srebhan merged 4 commits into
influxdata:masterfrom
mstrandboge:fix/4658
Jan 29, 2024
Merged

feat(inputs.net): Add speed metric#14625
srebhan merged 4 commits into
influxdata:masterfrom
mstrandboge:fix/4658

Conversation

@mstrandboge
Copy link
Copy Markdown
Contributor

@mstrandboge mstrandboge commented Jan 24, 2024

Summary

Adds a speed metric, reading /sys/class/net/*/speed as documented here in the kernel documentation. Currently only implemented for Linux. There is a PR to gopsutil, shirou/gopsutil#1473, which implements this metric as part of its interface and supports more platforms, but we decided to move forward with implementing this ourselves for the time being.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #4658

@mstrandboge mstrandboge requested a review from powersj January 24, 2024 20:33
@telegraf-tiger telegraf-tiger Bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jan 24, 2024
powersj
powersj reviewed Jan 24, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick PR! Question about the -1.

Comment thread plugins/inputs/net/net.go Outdated
@powersj powersj self-assigned this Jan 24, 2024
Hipska
Hipska suggested changes Jan 25, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Hipska Hipska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to have a test for the -1 value.

Also, wouldn't it be better to already be on-par with the upstream gopsutil and have a separate field for in and out? Like speed_in and speed_out? (Seems to be only supported by Windows to have different values)

@powersj
Copy link
Copy Markdown
Contributor

powersj commented Jan 25, 2024

Also, wouldn't it be better to already be on-par with the upstream gopsutil and have a separate field for in and out? Like speed_in and speed_out? (Seems to be only supported by Windows to have different values)

The net plugin only supports linux. If someone eventually gets gopsutil support enabled for other distros, then that could be re-evaluted down the road for Windows users.

@mstrandboge mstrandboge requested a review from powersj January 25, 2024 20:27
powersj
powersj reviewed Jan 25, 2024
View reviewed changes
Comment thread plugins/inputs/net/net.go Outdated
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 25, 2024
@powersj powersj assigned srebhan and unassigned powersj Jan 25, 2024
@telegraf-tiger
Copy link
Copy Markdown
Contributor

telegraf-tiger Bot commented Jan 25, 2024

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@Hipska
Copy link
Copy Markdown
Contributor

Hipska commented Jan 26, 2024

The net plugin only supports linux.

Oh sorry, didn’t check that. Never mind my remark then.

srebhan
srebhan reviewed Jan 26, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DStrand1 thanks for the clean PR! Just one question about the return value...

Comment thread plugins/inputs/net/net.go
@srebhan srebhan merged commit 1e3597d into influxdata:master Jan 29, 2024
@github-actions github-actions Bot added this to the v1.30.0 milestone Jan 29, 2024
@mstrandboge mstrandboge deleted the fix/4658 branch January 29, 2024 20:27
hhiroshell pushed a commit to hhiroshell/telegraf that referenced this pull request Feb 1, 2024
@mstrandboge @hhiroshell
feat(inputs.net): Add speed metric (influxdata#14625)
db81492
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srebhan srebhan srebhan approved these changes

+2 more reviewers

@powersj powersj powersj approved these changes

@Hipska Hipska Hipska approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@srebhan srebhan

Labels

feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Milestone

v1.30.0

Development

Successfully merging this pull request may close these issues.

Report interface speed in net module

4 participants

@mstrandboge @powersj @Hipska @srebhan