ast-exporter: Do not process macros for the syntactic form of InitListExpr#1826
Open
Rua wants to merge 1 commit into
Open
ast-exporter: Do not process macros for the syntactic form of InitListExpr#1826Rua wants to merge 1 commit into
InitListExpr#1826Rua wants to merge 1 commit into
Conversation
fw-immunant
approved these changes
May 26, 2026
Contributor
fw-immunant
left a comment
fw-immunant
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the exporter, the
macroCallSitesvariable keeps track of which macro call sites have already been visited, so that only the outermost expression gets processed for that call site. But that depends on Clang's visiting order, and in the case of init lists, the syntactic form appears to be visited first, which then prevents macros from being associated with the semantic form. This PR skips macro processing for the syntactic form (which c2rust ignores anyway), fixing expansion for init lists in the transpiler.