Skip to content

Parallel DNG export #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
masc4ii wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Parallel DNG export #312

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f7906fd
ParallelDNG
masc4ii Feb 11, 2026
0331c27
One core per dng
masc4ii Feb 11, 2026
156ae1b
Parallel DNG for non-DualISO only
masc4ii Feb 11, 2026
85850af
Fix: full power DualISO
masc4ii Feb 11, 2026
3e577d2
Error on export
masc4ii Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
131 changes: 79 additions & 52 deletions platform/qt/MainWindow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
#include <math.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <omp.h>

#ifdef Q_OS_MACX
#include "AvfLibWrapper.h"
Expand Down Expand Up @@ -2851,77 +2852,103 @@ void MainWindow::startExportCdng(QString fileName)
picAR[2] = 1; picAR[3] = 1;
}

//Init DNG data struct
dngObject_t * cinemaDng = initDngObject( m_pMlvObject, m_codecProfile - 6, getFramerate(), picAR);

//Render one single frame for raw correction init
uint32_t frameSize = getMlvWidth( m_pMlvObject ) * getMlvHeight( m_pMlvObject ) * 3;
uint16_t * imgBuffer;
imgBuffer = ( uint16_t* )malloc( frameSize * sizeof( uint16_t ) );
getMlvProcessedFrame16( m_pMlvObject, 0, imgBuffer, QThread::idealThreadCount() );
free( imgBuffer );

//Output frames loop
for( uint32_t frame = m_exportQueue.first()->cutIn() - 1; frame < m_exportQueue.first()->cutOut(); frame++ )
std::atomic<int> doneFrames{0};
std::atomic<bool> abortFlag{false};
std::atomic<bool> errorFlag{false};

QTimer* progressTimer = new QTimer(this);
connect(progressTimer, &QTimer::timeout, this, [=,&doneFrames,&abortFlag]() {
m_pStatusDialog->ui->progressBar->setValue(doneFrames.load());
m_pStatusDialog->ui->progressBar->repaint();
m_pStatusDialog->drawTimeFromToDoFrames( totalFrames - doneFrames.load() + ( m_exportQueue.first()->cutIn() - 1 ) - 1 );
qApp->processEvents();
});
progressTimer->start(50);

uint32_t start = m_exportQueue.first()->cutIn() - 1;
uint32_t end = m_exportQueue.first()->cutOut();

QMutex mutex;

#pragma omp parallel if( m_pMlvObject->llrawproc->dual_iso == 0 )
{
QString dngName;
if( m_codecOption == CODEC_CNDG_DEFAULT ) dngName = dngName.append( "%1_%2.dng" )
.arg( fileName )
.arg( getMlvFrameNumber( m_pMlvObject, frame ), 6, 10, QChar('0') );
else dngName = dngName.append( "%1_1_%2-%3-%4_0001_C0000_%5.dng" )
.arg( fileName )
.arg( getMlvTmYear( m_pMlvObject ), 2, 10, QChar('0') )
.arg( getMlvTmMonth( m_pMlvObject ), 2, 10, QChar('0') )
.arg( getMlvTmDay( m_pMlvObject ), 2, 10, QChar('0') )
.arg( getMlvFrameNumber( m_pMlvObject, frame ), 6, 10, QChar('0') );
dngObject_t* localDng = initDngObject(
m_pMlvObject,
m_codecProfile - 6,
getFramerate(),
picAR
);

QString filePathNr = pathName;
filePathNr = filePathNr.append( "/" + dngName );
#pragma omp for schedule(dynamic)
for (uint32_t frame = start; frame < end; ++frame)
{
if (abortFlag.load())
continue;

QString dngName;
if( m_codecOption == CODEC_CNDG_DEFAULT ) dngName = dngName.append( "%1_%2.dng" )
.arg( fileName )
.arg( getMlvFrameNumber( m_pMlvObject, frame ), 6, 10, QChar('0') );
else dngName = dngName.append( "%1_1_%2-%3-%4_0001_C0000_%5.dng" )
.arg( fileName )
.arg( getMlvTmYear( m_pMlvObject ), 2, 10, QChar('0') )
.arg( getMlvTmMonth( m_pMlvObject ), 2, 10, QChar('0') )
.arg( getMlvTmDay( m_pMlvObject ), 2, 10, QChar('0') )
.arg( getMlvFrameNumber( m_pMlvObject, frame ), 6, 10, QChar('0') );

QString filePathNr = pathName;
filePathNr = filePathNr.append( "/" + dngName );

//Save cDNG frame
//Save cDNG frame
#ifdef Q_OS_UNIX
QString properties_fn = QStandardPaths::writableLocation(QStandardPaths::DocumentsLocation);
properties_fn.append("/mlv-dng-params.txt");
if( saveDngFrame( m_pMlvObject, cinemaDng, frame, filePathNr.toUtf8().data(), properties_fn.toUtf8().data() ) )
QString properties_fn = QStandardPaths::writableLocation(QStandardPaths::DocumentsLocation);
properties_fn.append("/mlv-dng-params.txt");
bool error = saveDngFrame( m_pMlvObject, localDng, frame, filePathNr.toUtf8().data(), properties_fn.toUtf8().data() );
#else
QString properties_fn = QStandardPaths::writableLocation(QStandardPaths::DocumentsLocation);
properties_fn.append("\\mlv-dng-params.txt");
if( saveDngFrame( m_pMlvObject, cinemaDng, frame, filePathNr.toLatin1().data(), properties_fn.toLatin1().data() ) )
QString properties_fn = QStandardPaths::writableLocation(QStandardPaths::DocumentsLocation);
properties_fn.append("\\mlv-dng-params.txt");
bool error = saveDngFrame( m_pMlvObject, localDng, frame, filePathNr.toLatin1().data(), properties_fn.toLatin1().data() );
#endif
{
m_pStatusDialog->close();
qApp->processEvents();
int ret = QMessageBox::critical( this,
tr( "MLV App - Export file error" ),
tr( "Could not save: %1\nHow do you like to proceed?" ).arg( dngName ),
tr( "Skip frame" ),
tr( "Abort current export" ),
tr( "Abort batch export" ),
0, 2 );
if( ret == 2 )
{
exportAbort();
}
if( ret > 0 )

if (error || m_exportAbortPressed)
{
break;
abortFlag = true;
errorFlag = true;
}
}

//Set Status
m_pStatusDialog->ui->progressBar->setValue( frame - ( m_exportQueue.first()->cutIn() - 1 ) + 1 );
m_pStatusDialog->ui->progressBar->repaint();
m_pStatusDialog->drawTimeFromToDoFrames( totalFrames - frame + ( m_exportQueue.first()->cutIn() - 1 ) - 1 );
qApp->processEvents();
//Check diskspace
mutex.lock();
checkDiskFull( filePathNr );
mutex.unlock();

//Check diskspace
checkDiskFull( filePathNr );
//Abort pressed? -> End the loop
if( m_exportAbortPressed ) break;
doneFrames++;

qApp->processEvents();
}

freeDngObject(localDng);
}

//Free DNG data struct
freeDngObject( cinemaDng );
m_pStatusDialog->close();
if( errorFlag.load() )
{
int ret = QMessageBox::critical( this,
tr( "MLV App - Export file error" ),
tr( "Error exporting DNG frame.\nAbort batch export?" ),
tr( "Yes" ),
tr( "No" ) );
if( ret == 0 )
{
exportAbort();
}
}

//Enable GUI drawing
m_dontDraw = false;
Expand Down