Skip to content

Wait a few frames before getting the window size to prevent bug where window doesn't open and size properly #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjgriffin42 merged 1 commit into from
Jul 10, 2026
Merged

Wait a few frames before getting the window size to prevent bug where window doesn't open and size properly #247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion ...alizer-jfx/src/main/java/us/ihmc/scs2/sessionVisualizer/jfx/tools/JavaFXMissingTools.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,11 +453,22 @@ public static void centerDialogInOwner(Dialog<?> dialog)
if (!dialog.isShowing())
{
// TODO Seems that on Ubuntu the changes done to the window position/size are not processed properly until the window is showing.
// TODO This should be fixed - Nick
// This may be related to the bug reported when using GTK3: https://github.com/javafxports/openjdk-jfx/pull/446, might be fixed in later version.
dialog.setOnShown(e ->
{
runLater(JavaFXMissingTools.class, () ->
runNFramesLater(5, () ->
{
// The dialog may already have been dismissed by the time this runs; its DialogPane
// is detached from its Scene in that case, so bail out rather than NPE.
if (!dialog.isShowing())
return;

Scene dialogScene = dialog.getDialogPane().getScene();
if (dialogScene == null || dialogScene.getWindow() == null)
return;

dialogScene.getWindow().sizeToScene();
dialog.setX(owner.getX() + 0.5 * (owner.getWidth() - dialog.getWidth()));
dialog.setY(owner.getY() + 0.5 * (owner.getHeight() - dialog.getHeight()));
});
Expand Down
Loading