Add try_into_inner() for ISO9660 and FileRef#2
Add try_into_inner() for ISO9660 and FileRef#2losynix wants to merge 1 commit intoids1024:masterfrom
Conversation
Hm, yeah. A I'm not entirely happy with how reference counting is used in the crate in general, but I'm not sure the most efficient and ergonomic Rust API for ISO9660 (and filesystems generally; though is simpler in that it's read only). |
|
|
|
I'm not sure what the best approach for a filesystem API would be either. Other crates I checked like rust-fatfs or ext4-rs take ownership of the inner reader whereas ntfs asks for the reader in every functions accessing the filesystem. Anyway you're right I can probably get around this by giving a reference to |
7a2bb3e to
895f3d4
Compare
Hello !
It would be nice to get ownership of the inner reader back when we're done. Not sure this is the best approach, FileRef makes this tricky but it works for me.