feat: ✨ room image shown on hover#568
Open
arya-palanivel wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
5 issues found across 4 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="scripts/fetch-room-images.ts">
<violation number="1" location="scripts/fetch-room-images.ts:130">
P1: Unconditional file write can clobber committed image data with empty/partial output on transient network failures. Add a guard to fail fast before writing when results are unexpectedly empty.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| ].join("\n"); | ||
|
|
||
| const outPath = path.resolve(__dirname, "../src/lib/rooms/room-images.ts"); | ||
| await fs.writeFile(outPath, lines, "utf-8"); |
Contributor
There was a problem hiding this comment.
P1: Unconditional file write can clobber committed image data with empty/partial output on transient network failures. Add a guard to fail fast before writing when results are unexpectedly empty.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At scripts/fetch-room-images.ts, line 130:
<comment>Unconditional file write can clobber committed image data with empty/partial output on transient network failures. Add a guard to fail fast before writing when results are unexpectedly empty.</comment>
<file context>
@@ -0,0 +1,137 @@
+ ].join("\n");
+
+ const outPath = path.resolve(__dirname, "../src/lib/rooms/room-images.ts");
+ await fs.writeFile(outPath, lines, "utf-8");
+ console.log(`\nWrote ${found} image entries → src/lib/rooms/room-images.ts`);
+}
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrades the plain text tooltip on study room heatmap cells to a rich card that shows a room photo, name, time range, capacity, and description on hover.
AnteaterAPI doesn't return image URLs. UCI Libraries also doesn't expose a public API for room photos. However, the public booking pages do contain room photos hosted on UCI's S3/CloudFront CDN.
So there is a one-time dev script that:
This file is committed to the repo and imported directly into the heatmap component. If UCI adds new rooms or updates photos, we can just re-run the script to regenerate it.
Currently 77 rooms have images. The remaining rooms (Plaza Verde and some MRC rooms) simply have no photo uploaded on UCI's side so they only show the text part rn. The long-term fix would be getting AnteaterAPI to return image URLs but thats it own issue.
Recording/Screenshots
Test Plan