feat: ✨ rooms rec mobile#567
Open
ethancha0 wants to merge 2 commits into
Open
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/components/availability/mobile-group-responses.tsx">
<violation number="1" location="src/components/availability/mobile-group-responses.tsx:43">
P3: Rooms label uses a hardcoded plural "Rooms", causing "1 Rooms" when roomCount is 1 instead of "1 Room".</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| onOpenRooms, | ||
| onSchedule, | ||
| }: MobileGroupResponsesProps) { | ||
| const roomsLabel = hasSearchedRooms ? `${roomCount} Rooms` : "Rooms"; |
Contributor
There was a problem hiding this comment.
P3: Rooms label uses a hardcoded plural "Rooms", causing "1 Rooms" when roomCount is 1 instead of "1 Room".
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/components/availability/mobile-group-responses.tsx, line 43:
<comment>Rooms label uses a hardcoded plural "Rooms", causing "1 Rooms" when roomCount is 1 instead of "1 Room".</comment>
<file context>
@@ -20,23 +21,40 @@ export interface MobileGroupResponsesProps {
+ onOpenRooms,
onSchedule,
}: MobileGroupResponsesProps) {
+ const roomsLabel = hasSearchedRooms ? `${roomCount} Rooms` : "Rooms";
+
return (
</file context>
Contributor
There was a problem hiding this comment.
1 issue found across 3 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/components/availability/mobile-room-wheel-picker.tsx">
<violation number="1" location="src/components/availability/mobile-room-wheel-picker.tsx:39">
P3: Room filtering logic is duplicated across mobile and sidebar implementations, creating a drift-prone maintenance path.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| buildings: selectedBuildings, | ||
| } = filters; | ||
|
|
||
| const rooms = useMemo(() => { |
Contributor
There was a problem hiding this comment.
P3: Room filtering logic is duplicated across mobile and sidebar implementations, creating a drift-prone maintenance path.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/components/availability/mobile-room-wheel-picker.tsx, line 39:
<comment>Room filtering logic is duplicated across mobile and sidebar implementations, creating a drift-prone maintenance path.</comment>
<file context>
@@ -0,0 +1,251 @@
+ buildings: selectedBuildings,
+ } = filters;
+
+ const rooms = useMemo(() => {
+ const all = deduplicateRooms(rawRooms);
+ return all.filter((room) => {
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recording/Screenshots
Test Plan
Issues