Skip to content

IBX-11766: Replaced phpunit assertions with webmozart equivalents#1920

Merged
bnowak merged 4 commits into
5.0from
IBX-11766-replace-phpunit-assertions-with-webmozart-library
May 22, 2026
Merged

IBX-11766: Replaced phpunit assertions with webmozart equivalents#1920
bnowak merged 4 commits into
5.0from
IBX-11766-replace-phpunit-assertions-with-webmozart-library

Conversation

@bnowak
Copy link
Copy Markdown
Contributor

@bnowak bnowak commented May 19, 2026

Caution

  • Remove tmp commits before merging
🎫 Issue IBX-11766

Related PRs:

ibexa/behat#184

Description:

Installed webmozart/assert library as require-dev dependency. It's still a bit "hidden" dependency (because behat package use assertions from /src directory), but at least it's defined in this specific library. Previously, phpunit was installed by indirect dependency from ibexa/behat package.

Replaced phpunit assertions with these from webmozart library.

For QA:

Documentation:

@bnowak bnowak force-pushed the IBX-11766-replace-phpunit-assertions-with-webmozart-library branch from 8dd3186 to 784fd4d Compare May 19, 2026 12:30
@bnowak bnowak force-pushed the IBX-11766-replace-phpunit-assertions-with-webmozart-library branch 7 times, most recently from 41db74b to 007cf97 Compare May 21, 2026 09:23
@bnowak bnowak marked this pull request as ready for review May 21, 2026 09:23
Comment thread src/lib/Behat/Page/ContentUpdateItemPage.php Outdated
Comment thread src/lib/Behat/Page/ContentUpdateItemPage.php Outdated
@bnowak bnowak force-pushed the IBX-11766-replace-phpunit-assertions-with-webmozart-library branch from d9d043d to 336d62c Compare May 22, 2026 10:17
@bnowak bnowak force-pushed the IBX-11766-replace-phpunit-assertions-with-webmozart-library branch from 336d62c to 7b0c919 Compare May 22, 2026 10:23
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
5.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@bnowak bnowak merged commit c756be1 into 5.0 May 22, 2026
21 of 25 checks passed
@bnowak bnowak deleted the IBX-11766-replace-phpunit-assertions-with-webmozart-library branch May 22, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants