fix(potree2): incorrect node info#2800
Open
Desplandis wants to merge 1 commit into
Open
Conversation
Desplandis
force-pushed
the
fix/potree2-hierarchy
branch
from
165f0e1 to
e0e9c7a
Compare
Contributor
Author
|
@ftoromanoff Could you review this fix? I relaunched the functional tests. |
ftoromanoff
requested changes
Jun 30, 2026
ftoromanoff
left a comment
ftoromanoff
left a comment
Contributor
There was a problem hiding this comment.
Nice rewrite of the tests with sinon.sandBox !
Comment on lines
+7
to
+9
| const NODE_TYPE_NORMAL = 0; | ||
| const NODE_TYPE_LEAF = 1; | ||
| const NODE_TYPE_PROXY = 2; |
Contributor
There was a problem hiding this comment.
Maybe we should use the same writing as in Potree2Node.js ?
const NODE_TYPE = {
NORMAL: 0,
LEAF: 1,
PROXY: 2,
}
And same in Potree2Node.js.
use
const BYTES_PER_NODE = 22; at file level instead of using const bytesPerNode = 22; in the parseHierarchy() function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a hierarchy issue in Potree 2.x datasets where the child hierarchy was not correctly loaded due to a typo.
Added some tests too to catch similar future regressions.