Move SkyManager post-processing functionality to a separate class#2720
Draft
HoloTheDrunk wants to merge 18 commits into
Draft
Move SkyManager post-processing functionality to a separate class#2720HoloTheDrunk wants to merge 18 commits into
HoloTheDrunk wants to merge 18 commits into
Conversation
…eorganize renderer.shadowMap setting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue description is a WIP
Description
Takes the post-processing setup of SkyManager and moves it to a new class called AtmosphereManager.
Linked to #2719
Motivation and Context
SkyManager used to setup both objects in the scene and post-processing passes, which muddied its responsibilities and made it harder to reason about the code's behavior.