chore(pointcloud): Add adaptive size mode by ketourneau · Pull Request #2666 · iTowns/itowns

ketourneau · 2025-12-22T10:34:27Z

Description

Motivation and Context

Our customer needs it to draw on pointcloud.

Screenshots (if appropriate)

Enregistrement.de.l.ecran.2025-12-17.a.08.51.43.mov

ketourneau · 2025-12-22T10:36:24Z

I see an issue with postUpdate, pointcloud size is wrong at initialisation (postUpdate is called before points loaded) : #2665

jailln · 2026-05-13T08:47:48Z

@ketourneau nice addition thanks ! Tested ok on 3D Tiles datasets 🙂

I think we should modify the point clouds examples (including 3dtiles_loader.html) to use this display mode. WDYT @Desplandis ?

jailln · 2026-05-19T08:00:57Z

@ketourneau nice addition thanks ! Tested ok on 3D Tiles datasets 🙂

I think we should modify the point clouds examples (including 3dtiles_loader.html) to use this display mode. WDYT @Desplandis ?

After discussion with @ketourneau it is not applied to 3D Tiles layers because the implementation is based on the assumption that the data is organized in an octree. I'm not familiar enough with this algorithm to know if and how it could be adapted to 3D tiles but it should not block this PR. We should however add in the doc and maybe in a warning that it is not supported for 3D Tiles layers.

ftoromanoff · 2026-06-17T09:24:00Z

Small remarks for the PointCloudDebug. The 'Min size' and 'Max size' are not use for the 'new 'ADAPTIVE' 'Size mode', are they ? In this case the should be hidden as for when we set the 'Size mode' on 'VALUE'.

Desplandis · 2026-06-18T08:12:18Z

+            const data = vnt.image.data;
+            data.set(this._visibilityTextureData.data);


Suggested change

const data = vnt.image.data;

data.set(this._visibilityTextureData.data);

const data = vnt.image.data;

data.fill(0);

data.set(this._visibilityTextureData.data);

I think there are still some stale entries from the previous updates, I recommend you to zero out all the buffer. It is weird however that we access those part of the buffer but it shall fix the issue for now.

Indeed, good point.

Desplandis · 2026-06-18T08:23:19Z

+            for (const pts of this.group.children) {
+                const node = pts.userData.node;
+                const depth = node.depth;
+                const nodeStartOffset = this._visibilityTextureData.nodeToIndex.get(node);


Beware that nodeStartOffset may be undefined! This is can happen because the rendered group this.group.children do not guarantee that all points are visible. They are in the rendered group (were visible once) but remain hidden until disposal (10s later).

Ok I continue to next iteration if nodeStartOffset is undefined

Desplandis · 2026-06-18T08:32:29Z

+        float nodeSizeAtLevel = octreeSize / pow(2.0, i + nodeDepth);
+
+        vec3 index3d = (pos - offset) / nodeSizeAtLevel;
+        index3d = floor(index3d + 0.5);


I think the more important issue of all. It seems that index3d may be outside the range $[0, 1]$. Clamping here fix the big points issues. It may be because of floating point error accumulation or because we are outside the bounds...

Okay, I applied your suggestion.

Desplandis · 2026-06-18T08:40:03Z

+        index3d = floor(index3d + 0.5);
+        int index = int(round(4.0 * index3d.x + 2.0 * index3d.y + index3d.z));
+
+        vec4 value = texture2D(visibleNodes, vec2(float(iOffset) / 2048.0, 0.0));


Suggested change

vec4 value = texture2D(visibleNodes, vec2(float(iOffset) / 2048.0, 0.0));

vec4 value = texture2D(visibleNodes, vec2((float(iOffset) + 0.5) / 2048.0, 0.5));

I suggest to sample at mid-pixel in case of a small floating-point error to not sample the neighbour texel.

Okay, I applied your suggestion.

ketourneau · 2026-06-18T08:47:57Z

Small remarks for the PointCloudDebug. The 'Min size' and 'Max size' are not use for the 'new 'ADAPTIVE' 'Size mode', are they ? In this case the should be hidden as for when we set the 'Size mode' on 'VALUE'.

Yes, indeed, I had asked myself the same question. I hided the 'Min size' and 'Max size'

ftoromanoff · 2026-06-22T13:51:18Z

@@ -299,7 +299,7 @@ export default {
        styleUI.add(layer, 'opacity', 0, 1).name('Layer opacity').onChange(update);
        styleUI.add(layer, 'pointSize', 0, 15).name('Point size').onChange(update);


This parameter initialy only have an impact on Size mode = VALUE (and not when Size mode = ATTENUATED) thus it should be put under 'Size mode' and be hidden when we are 'ATTENUATED' ?
Now i see that in the mode = ADAPTIVE, it's also has an impact even if i don't really understand to what exactly the value will refer to.

In ADAPTIVE mode this parameter can be use to apply a scale factor. But normally, 1.0 factor value should be enough in most cases

I would then still suggest to move this parameter after the 'Size mode' button and hide it when it has no impact. It is just purely ergonic and not algorythmic.

It's fine by me. I don't validate the PR as I didn't review the rest of the code. I'll let @Desplandis do that.

# Conflicts: # packages/Main/src/Layer/PointCloudLayer.ts

… change # Conflicts: # packages/Main/src/Layer/PointCloudLayer.ts # Conflicts: # packages/Main/src/Layer/PointCloudLayer.ts

…clouds whose source CRS differs from the scene CRS)

…ear texture

…g-point error to not sample the neighbour texel

… reprojection)

…ALUE or ADAPTIVE mode

ketourneau force-pushed the f/adaptive_size_mode branch from 7afe5c3 to 49a686f Compare December 24, 2025 13:28

mgermerie assigned Desplandis Jan 5, 2026

Desplandis mentioned this pull request Jan 19, 2026

Fix(pointcloud): incorrect loading mechanism & add layer events #2673

Merged

ketourneau force-pushed the f/adaptive_size_mode branch 3 times, most recently from d124dc9 to 31b11dc Compare February 3, 2026 09:01

ketourneau force-pushed the f/adaptive_size_mode branch 6 times, most recently from 40b5fb7 to 90df547 Compare March 11, 2026 08:57

ketourneau force-pushed the f/adaptive_size_mode branch 8 times, most recently from 75ba231 to 1fb2419 Compare March 17, 2026 13:35

Desplandis reviewed Mar 19, 2026

View reviewed changes

Comment thread packages/Main/src/Layer/PointCloudLayer.ts

ketourneau force-pushed the f/adaptive_size_mode branch from 1fb2419 to aae36f4 Compare March 19, 2026 15:26

Desplandis reviewed Mar 19, 2026

View reviewed changes

Comment thread packages/Main/src/Layer/PointCloudLayer.ts Outdated

ketourneau force-pushed the f/adaptive_size_mode branch 6 times, most recently from 5a70f87 to cf37835 Compare March 24, 2026 10:46

ketourneau force-pushed the f/adaptive_size_mode branch from 609b339 to 22bbf6e Compare May 19, 2026 12:53

ketourneau force-pushed the f/adaptive_size_mode branch from 22bbf6e to b7766c6 Compare June 3, 2026 08:42

ketourneau force-pushed the f/adaptive_size_mode branch from b7766c6 to baef75b Compare June 10, 2026 09:40

Desplandis reviewed Jun 18, 2026

View reviewed changes

ketourneau force-pushed the f/adaptive_size_mode branch from baef75b to 1938853 Compare June 18, 2026 08:41

ketourneau force-pushed the f/adaptive_size_mode branch 2 times, most recently from cbd072a to fde42d5 Compare June 18, 2026 14:57

ftoromanoff reviewed Jun 22, 2026

View reviewed changes

ketourneau added 14 commits June 30, 2026 09:37

chore(pointcloud): Add adaptive size mode

4a5ca7c

# Conflicts: # packages/Main/src/Layer/PointCloudLayer.ts

chore(pointcloud): Compute visibility texture only if node visibility…

33d1352

… change # Conflicts: # packages/Main/src/Layer/PointCloudLayer.ts # Conflicts: # packages/Main/src/Layer/PointCloudLayer.ts

chore(pointcloud): Move computeVisibility method to utils

98e5409

chore(pointcloud): Use nodeToIndex

b8607cf

chore(pointcloud): refactor pointCloudNode sort

ac72acc

chore(pointcloud): Fix pointCloudLayer (produce wrong LODs for point …

f0086fd

…clouds whose source CRS differs from the scene CRS)

chore(pointcloud): Add unit test for adaptivePointSize

fce77c8

chore(pointcloud): Hide not required filed in PointCloudDebug, fix cl…

b41e8fb

…ear texture

chore(pointcloud): Fix sample at mid-pixel in case of a small floatin…

aaaf60b

…g-point error to not sample the neighbour texel

chore(pointcloud): Add clamp to be sure index3d can't be outside [0,1]

12185a0

chore(pointcloud): Use vec3 for octreeSize (hack to handle globe view…

ab79645

… reprojection)

chore(pointcloud): Fix lint

c2975c1

chore(pointcloud): Add documentation

a75b492

chore(pointcloud): Show pointSize below sizeMode button and only in V…

ab341b2

…ALUE or ADAPTIVE mode

ketourneau force-pushed the f/adaptive_size_mode branch from e5fbf4c to ab341b2 Compare June 30, 2026 07:37

		const data = vnt.image.data;
		data.set(this._visibilityTextureData.data);

	vec4 value = texture2D(visibleNodes, vec2(float(iOffset) / 2048.0, 0.0));
	vec4 value = texture2D(visibleNodes, vec2((float(iOffset) + 0.5) / 2048.0, 0.5));

		@@ -299,7 +299,7 @@ export default {
		styleUI.add(layer, 'opacity', 0, 1).name('Layer opacity').onChange(update);
		styleUI.add(layer, 'pointSize', 0, 15).name('Point size').onChange(update);

Uh oh!

Conversation

ketourneau commented Dec 22, 2025

Description

Motivation and Context

Screenshots (if appropriate)

Uh oh!

ketourneau commented Dec 22, 2025

Uh oh!

Uh oh!

Uh oh!

jailln commented May 13, 2026

Uh oh!

jailln commented May 19, 2026

Uh oh!

ftoromanoff commented Jun 17, 2026

Uh oh!

Desplandis Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ketourneau commented Jun 18, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ftoromanoff Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ftoromanoff Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Desplandis Jun 18, 2026 •

edited

Loading

ftoromanoff Jun 22, 2026 •

edited

Loading

ftoromanoff Jun 23, 2026 •

edited

Loading