test(build-tier): expect sanitised wire tool names (fix red main)#32
Merged
Conversation
buildToolsList emits commandIdToToolName(cmd.id) — dots -> underscores (refs #24) — but the Phase 4 tier-mirror e2e test still asserted dotted names (app.a / app.c), so AC2/AC3/AC4 failed and acture main has been red since 2026-05-28. Update the assertions to the wire form (app_a, app_c). Registry-lookup-by-id assertions stay dotted (ids are unchanged).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
acture
mainhas been red since 2026-05-28:packages/build-tierPhase 4 tier-mirror e2e asserted dotted tool names (app.a/app.c) frombuildToolsList, which emits sanitised wire names (commandIdToToolName: dots → underscores, refs #24). Updated AC2/AC3/AC4 to the wire form (app_a/app_c). Registry-lookup-by-id assertions stay dotted (ids unchanged).Same class of staleness as thorwhalen/reelee-web#113. Full monorepo test suite green locally.