client: read pending data before handling POLLHUP#27
Merged
Conversation
checking POLLHUP only when POLLIN is not set, ensuring any pending data is always drained before treating the connection as closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the server sends a fatal protocol error and immediately closes the
connection, poll(2) can return with both POLLHUP and POLLIN set
simultaneously. Previously POLLHUP was checked first, causing the client
to return early without reading the pending data off the socket.
This was observed as a flaky autopkgtest failure on slower architectures
(ppc64el) where the server's fatal error message and connection close
arrive in the same poll cycle, while on faster hardware (amd64) they
typically arrive in separate cycles masking the bug.
good: https://ci.debian.net/packages/h/hyprwire/testing/amd64/70722966/
bad: https://ci.debian.net/packages/h/hyprwire/testing/ppc64el/70910866/