identify high priority issue in fabric codebase#257
Open
sahildando wants to merge 3 commits into
Open
Conversation
Correct spelling and terminology issues in README.md to improve clarity for contributors and align component/repo naming with Fabric-X conventions. Also includes one structural text cleanup by renaming the "Differencies" subsection to "Differences". No functional code changes were made. Signed-off-by: Codex <codex@openai.com>
docs: fix typos and naming inconsistencies in README
MarkFlagRequired returns an error when the target flag cannot be found. The current binding helpers discarded that error, which can hide command wiring problems during CLI setup. Check the returned error for both required flags and fail fast with panic(err) to avoid silently continuing with misconfigured commands. Signed-off-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Additional details (Optional)
Related issues