Skip to content

fix(fxconfig): prevent reuse of closed gRPC clients in app services #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ARYANPATEL-BIT wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(fxconfig): prevent reuse of closed gRPC clients in app services #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions tools/fxconfig/internal/app/list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@ func (d *AdminApp) ListNamespaces(ctx context.Context) ([]NamespaceQueryResult,
if err != nil {
return nil, err
}
defer func() {
_ = qc.Close()
}()

res, err := qc.GetNamespacePolicies(ctx)
if err != nil {
Expand Down
9 changes: 0 additions & 9 deletions tools/fxconfig/internal/app/submit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@ func (d *AdminApp) SubmitTransaction(ctx context.Context, txID string, tx *appli
if err != nil {
return fmt.Errorf("failed to prepare submission: %w", err)
}
defer func() {
_ = sc.ordererClient.Close()
}()

if err := sc.ordererClient.Broadcast(ctx, sc.signingIdentity, txID, tx); err != nil {
return fmt.Errorf("failed to broadcast transaction: %w", err)
Expand All @@ -46,19 +43,13 @@ func (d *AdminApp) SubmitTransactionWithWait(ctx context.Context, txID string, t
if err != nil {
return UnknownStatus, fmt.Errorf("failed to prepare submission: %w", err)
}
defer func() {
_ = sc.ordererClient.Close()
}()

// get notification client
nc, err := d.NotificationProvider.Get()
if err != nil {
return UnknownStatus, fmt.Errorf("failed to get notification client: %w", err)
}

defer func() {
_ = nc.Close()
}()

subscription, err := nc.Subscribe(ctx, txID)
if err != nil {
Expand Down