fix(cryptogen): improve error handling and add config parsing test#235
Open
sachin9058 wants to merge 1 commit into
Open
fix(cryptogen): improve error handling and add config parsing test#235sachin9058 wants to merge 1 commit into
sachin9058 wants to merge 1 commit into
Conversation
Signed-off-by: Sachin Kumar <sachinkumar905846@gmail.com>
Contributor
Author
|
Hi @mbrandenburger, I’ve incorporated the suggested improvements and cleaned up the error handling and tests in this PR. Would appreciate your review when you get a chance. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR improves error handling in the cryptogen CLI and adds test coverage for configuration parsing failures.
Changes include:
These changes improve reliability and make failures easier to diagnose without modifying core functionality.