feat(fxconfig): add basic snapshot validation helper and tests#228
Open
sachin9058 wants to merge 1 commit into
Open
feat(fxconfig): add basic snapshot validation helper and tests#228sachin9058 wants to merge 1 commit into
sachin9058 wants to merge 1 commit into
Conversation
Signed-off-by: Sachin Kumar <sachinkumar905846@gmail.com>
2d2ab31 to
504d3cc
Compare
Contributor
Author
|
I’ve opened this PR to add a minimal snapshot validation helper with unit tests. The goal is to introduce a lightweight validation step for snapshot-like data structures without affecting existing logic. Would really appreciate your feedback whenever you get a chance. Happy to refine this further based on your suggestions. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR introduces a minimal validation helper for snapshot-like data structures to ensure basic structural correctness before processing.
The validation checks:
The goal is to provide a lightweight guard against malformed snapshot input, helping prevent issues during transformation or export stages.
Unit tests are included to cover both valid and invalid scenarios.
Additional details (Optional)
internal/validationto keep the scope minimalValidation:
go test ./tools/fxconfig/... -count=1passedmake lintpassedRelated issues
Closes #227