fix(fxconfig/cli): enforce --submit and --wait flag dependencies#220
Open
ARYANPATEL-BIT wants to merge 1 commit into
Open
fix(fxconfig/cli): enforce --submit and --wait flag dependencies#220ARYANPATEL-BIT wants to merge 1 commit into
ARYANPATEL-BIT wants to merge 1 commit into
Conversation
Signed-off-by: ARYANPATEL-BIT <aryan.patel7291@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Background & Motivation
Currently, in the
fxconfig namespace createandupdateCLI commands, the--submitflag documentation states that it "requires --endorse". However, this constraint is not enforced programmatically.As a result:
--submitwithout--endorsesimply returns early and saves an unsigned transaction, completely ignoring the user's intent to submit.--endorsewithout--submitsucceeds in endorsing the transaction but offers no console output or guidance to the user on what to do next.What was changed
Validate()method tonamespaceDeployFlagsinflags.goto enforce the following dependencies:--submitstrictly requires--endorse.--waitstrictly requires--submit.namespace_create.goandnamespace_update.goto executenamespace.Validate()early in theRunEflow.--endorsewithout--submit. It informs the user that the transaction was endorsed successfully and instructs them to usefxconfig tx submitlater.--helpstrings (Longdocumentation) to clarify exactly how these lifecycle flags interact.Testing
flags_test.gocovering all valid and invalid flag permutations.FIXES: #219