fix(fxconfig): defer CloseSend on broadcast stream to prevent connection leak (#209)#216
Open
SAY-5 wants to merge 1 commit into
Open
fix(fxconfig): defer CloseSend on broadcast stream to prevent connection leak (#209)#216SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
…ion leak (hyperledger#209) Signed-off-by: SAY-5 <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #209.
OrdererClient.send()opens a gRPC broadcast stream viaoc.client.Broadcast(ctx)but never callsCloseSend(). On every error path (Sendfailure,Recvfailure, non-SUCCESS status) and even on the success path, the stream is abandoned. The underlying gRPC connection is held untilctxcancellation rather than released immediately, leaking one stream per call.Change
tools/fxconfig/internal/client/orderer.go:82, adddefer abc.CloseSend()immediately after the stream is successfully opened.CloseSendonly signals end-of-send to the server; it doesn't tear down the connection or affect the in-flightRecv, so all four exit paths now release the stream cleanly.Test plan
go build ./tools/fxconfig/..., cleango vet ./tools/fxconfig/..., cleanRecvstill runs afterSendand returns the same status beforedeferfires