Fix / Gamma support for hummingbot with oracle based swaps (#1)#453
Open
0xcrust wants to merge 2 commits into
Open
Fix / Gamma support for hummingbot with oracle based swaps (#1)#4530xcrust wants to merge 2 commits into
0xcrust wants to merge 2 commits into
Conversation
|
cc @fengtality |
* Add connector and routes for gfx gamma normal swaps * Swap with oracle * Update goosefx-amm-sdk
Contributor
|
@usgoose thanks for this PR. As an update, we need more time to standardize the Hummingbot client <> Gateway API communication interface. You can follow the updates in this Hummingbot branch https://github.com/hummingbot/hummingbot/tree/feat/gateway-2.8, along with the #amm-connectors channel in the Hummingbot Discord. Since some changes will be needed on the connector side, we will wait until that is done before reviewing and merging PRs for new DEX connectors and chains The ETA for completion is 1-2 months. I apologize for this delay, but I think it's in the long-term interests of both DEX connector maintainers and users to get the architecture right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add connector and routes for gfx gamma normal swaps
Swap with oracle
Update goosefx-amm-sdk
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Adds support for GooseFx's Gamma AMM to the Gateway API
Tests performed by the developer:
Tips for QA testing: