fix hasBeenCalled function#147
Merged
Merged
Conversation
Nowele
approved these changes
Mar 11, 2026
Nowele
left a comment
Collaborator
There was a problem hiding this comment.
yarn run-s clean build test
PASS test/e2e/parameterized/parameterized.test.js
PASS test/e2e/simple-suites/simple-suites.test.js
PASS test/e2e/assert/assert.test.js
PASS test/e2e/before-after/before-after.test.js
PASS test/e2e/selection/selection.test.js
PASS test/runner/file-match.test.ts (7.907 s)
PASS test/reporter/jest-reporter.test.ts (8.38 s)
Test Suites: 7 passed, 7 total
Tests: 33 passed, 33 total
Snapshots: 0 total
Time: 8.965 s
olenahuchko
reviewed
Mar 17, 2026
olenahuchko
left a comment
Collaborator
There was a problem hiding this comment.
Your fix looks great to me, also verified with some other test cases:
mockFunc = _brs_.mockFunction("testHasBeenCalledWith", sub (value as boolean) : end sub)
m.node.callFunc("testHasBeenCalledWith", true)
m.assert.hasBeenCalledWith(mockFunc, [false], "") ' - failed 🟢
m.assert.deepEquals([true], [false], "") ' - failed 🟢
m.assert.deepEquals({value: true}, {value: false}, "") ' - passed 🔴
m.assert.deepEquals(true, false, "") ' - passed 🔴
The last two are not related to hasBeenCalled, but it would be great to get it fixed as well here or maybe in the separate ticket
Collaborator
Author
Yes, let's create a separate ticket for deepEquals |
olenahuchko
approved these changes
Mar 19, 2026
Collaborator
Author
|
merging this in as this PR has 2 approvals |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added functionality to compare values inside deepEquals function, and tests for testing
