Skip to content

fix(hk): exclude hugoh/go-tools pins from pinact's comment management#253

Merged
hugoh merged 1 commit into
mainfrom
fix/pinact-go-tools-exclude
Jul 4, 2026
Merged

fix(hk): exclude hugoh/go-tools pins from pinact's comment management#253
hugoh merged 1 commit into
mainfrom
fix/pinact-go-tools-exclude

Conversation

@hugoh

@hugoh hugoh commented Jul 4, 2026

Copy link
Copy Markdown
Owner

Strip the # vX.Y.Z comment pinact previously added to the self-referential hugoh/go-tools workflow pins, and exclude them from pinact going forward. The go-tools template renders these pins as a raw commit hash with no comment, so a locally-added comment causes copier update's 3-way merge to conflict on that line every go-tools release. Companion fix: hugoh/go-tools@v1.1.1.

@hugoh hugoh enabled auto-merge (squash) July 4, 2026 12:18
@deepsource-io

deepsource-io Bot commented Jul 4, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 56ef031...d75e6fa on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
Go Jul 4, 2026 12:25p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

Strip the comment pinact previously added to the self-referential go-tools
pins, and exclude them going forward, so copier update's 3-way merge stops
conflicting on these lines every go-tools release.
@hugoh hugoh force-pushed the fix/pinact-go-tools-exclude branch from 848d784 to d75e6fa Compare July 4, 2026 12:25
@sonarqubecloud

sonarqubecloud Bot commented Jul 4, 2026

Copy link
Copy Markdown

@hugoh hugoh merged commit eb360c4 into main Jul 4, 2026
6 checks passed
@hugoh hugoh deleted the fix/pinact-go-tools-exclude branch July 4, 2026 12:26
@codecov

codecov Bot commented Jul 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.15%. Comparing base (56ef031) to head (d75e6fa).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #253   +/-   ##
=======================================
  Coverage   92.15%   92.15%           
=======================================
  Files           6        6           
  Lines         408      408           
=======================================
  Hits          376      376           
  Misses         25       25           
  Partials        7        7           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant