feat/scan

cmd/completions.go

@@ -33,7 +33,10 @@ func completeGroups(cfg *config.Config) []string {
 	return names
 }
 
-func repoGroupCompleter(cfgPath *string) func(context.Context, *cli.Command) {
+func makeCompleter(
+	cfgPath *string,
+	getters ...func(*config.Config) []string,
+) func(context.Context, *cli.Command) {
 	return func(_ context.Context, cmd *cli.Command) {
 		cfg, err := config.Load(*cfgPath)
 		if err != nil {
@@ -42,42 +45,22 @@ func repoGroupCompleter(cfgPath *string) func(context.Context, *cli.Command) {
 
 		w := cmd.Root().Writer
 
-		for _, name := range completeRepos(&cfg) {
-			_, _ = fmt.Fprintln(w, name)
-		}
-
-		for _, name := range completeGroups(&cfg) {
-			_, _ = fmt.Fprintln(w, name)
+		for _, get := range getters {
+			for _, name := range get(&cfg) {
+				_, _ = fmt.Fprintln(w, name)
+			}
 		}
 	}
 }
 
-func reposOnlyCompleter(cfgPath *string) func(context.Context, *cli.Command) {
-	return func(_ context.Context, cmd *cli.Command) {
-		cfg, err := config.Load(*cfgPath)
-		if err != nil {
-			return
-		}
-
-		w := cmd.Root().Writer
+func repoGroupCompleter(cfgPath *string) func(context.Context, *cli.Command) {
+	return makeCompleter(cfgPath, completeRepos, completeGroups)
+}
 
-		for _, name := range completeRepos(&cfg) {
-			_, _ = fmt.Fprintln(w, name)
-		}
-	}
+func reposOnlyCompleter(cfgPath *string) func(context.Context, *cli.Command) {
+	return makeCompleter(cfgPath, completeRepos)
 }
 
 func groupsOnlyCompleter(cfgPath *string) func(context.Context, *cli.Command) {
-	return func(_ context.Context, cmd *cli.Command) {
-		cfg, err := config.Load(*cfgPath)
-		if err != nil {
-			return
-		}
-
-		w := cmd.Root().Writer
-
-		for _, name := range completeGroups(&cfg) {
-			_, _ = fmt.Fprintln(w, name)
-		}
-	}
+	return makeCompleter(cfgPath, completeGroups)
 }

cmd/repo.go

@@ -62,7 +62,8 @@
 				Usage:   "add the repo(s) to this group",
 			},
 		},
-		Action: repoAddAction(cfgPath),
+		ShellComplete: func(_ context.Context, _ *cli.Command) {},
+		Action:        repoAddAction(cfgPath),
 	}
 }
 
@@ -125,7 +126,11 @@
 		cfg.AddRepoToGroup(name, group)
 	}
 
-	ui.Success("added %s as %q", abs, name)
+	if group != "" {
+		ui.Success("added %s as %q in group %s", abs, name, group)
+	} else {
+		ui.Success("added %s as %q", abs, name)
+	}
 
 	return nil
 }