Use integer conversion for Cpus and Gpus#535
Open
djw8605 wants to merge 1 commit into
Open
Conversation
The CPUs and GPUs are floats, for some reason. Convert to integer which makes it easier to parse with python classad bindings (for example in the gratia probe)
Member
|
So, in the near future we will be allocating fractional GPUs. And, allocating fractional CPUs in on the road map. What is the difficulty in parsing with the Python ClassAd bindings? Is there a bug there that we need to fix? |
|
Seems like a problem that the probe relies on MATCH_EXP_JOB_GLIDEIN_Cpus, which is not ensured to be there. The job should explicitly request to have attributes from the matching ad (slot ad) inserted into the job ad. As for converting to int, the patch looks simple enough, but we are wondering.... how does it become easier to parse with ClassAd bindings? Or perhaps you meant easier to parse without bindings? Or easier to work with? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CPUs and GPUs are floats, for some reason. Convert to integer
which makes it easier to parse with python classad bindings (for example
in the gratia probe)
The gratia probe reads
MATCH_EXP_JOB_GLIDEIN_Cpus.I am open to opinions.