Skip to content

DNM: cache test, manifest-only = warm hit#171787

Closed
bdraco wants to merge 1 commit into
cache-split-testsfrom
dnm-cache-manifest-only
Closed

DNM: cache test, manifest-only = warm hit#171787
bdraco wants to merge 1 commit into
cache-split-testsfrom
dnm-cache-manifest-only

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented May 21, 2026

Proposed change

DNM (do not merge). Empirical test for #171780.

Touches only homeassistant/components/cloud/manifest.json (no test or conftest change). The manifest change makes cloud a "core component" change, flipping CORE_ANY=true and triggering the full-suite path so Split tests for full run actually runs. Because no conftest or test file changed, the cache restored via restore-keys from the parent PR should be fully valid.

Expected behaviour in the Run split_tests.py step:

  • Cache: NNNN hits / 0 misses / NNNN total
  • Step finishes in roughly a second

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @home-assistant/cloud, mind taking a look at this pull request as it has been labeled with an integration (cloud) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of cloud can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign cloud Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

@bdraco bdraco closed this May 21, 2026
@bdraco bdraco deleted the dnm-cache-manifest-only branch May 21, 2026 21:44
@github-actions github-actions Bot locked and limited conversation to collaborators May 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant