Add OpenEVSE diagnostics#171762
Open
firstof9 wants to merge 14 commits into
Open
Conversation
Contributor
|
Hey there @c00w, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds diagnostics support for the OpenEVSE integration and introduces tests to validate returned data and redaction behavior.
Changes:
- Implement
async_get_config_entry_diagnosticsfor OpenEVSE, including charger property collection and config entry redaction. - Add tests for diagnostics output structure and credential redaction.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| homeassistant/components/openevse/diagnostics.py | New diagnostics endpoint implementation for OpenEVSE config entries. |
| tests/components/openevse/test_diagnostics.py | New tests validating diagnostics payload and sensitive-field redaction. |
bd872c9 to
320af57
Compare
…s, and loosen assertion
…100% code coverage
…spection comments, and correct assertions
… dynamic runtime attributes in production
…ndling, and assert async_setup success
…alization in diagnostics
…se deterministic dict key repr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add a diagnostics platform for OpenEVSE to provide details of the charger configuration and state for diagnostic purposes. Additionally, add comprehensive tests for the diagnostics platform, with proper mocking of the dynamic property lookup in the diagnostics code to avoid any memory leak/exhaustion issues.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: