Move service registration in System Bridge integration to async_setup#171761
Open
tr4nt0r wants to merge 9 commits into
Open
Move service registration in System Bridge integration to async_setup#171761tr4nt0r wants to merge 9 commits into
tr4nt0r wants to merge 9 commits into
Conversation
Contributor
|
Hey there @timmo001, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR extracts System Bridge service registration/handlers into a dedicated module and registers services during integration setup instead of per config entry.
Changes:
- Added
services.pywith service schemas + handlers (process lookup, open path/url, power commands, keyboard input). - Updated
__init__.pyto callasync_setup_services(hass)from a newasync_setup. - Removed the previous inline service registration code from
async_setup_entry.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| homeassistant/components/system_bridge/services.py | New module that defines and registers System Bridge services and implements the handlers. |
| homeassistant/components/system_bridge/init.py | Hooks service setup into async_setup and removes the prior inline service code. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
tr4nt0r
force-pushed
the
move_service_registration_to_async_setup
branch
from
c5ee7de to
9e27b19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
service.async_get_config_entryhelper to retrieve config entry and coordinatorServiceValidationErrorandHomeAssistantErrorType of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: