Fix hardcoded exception strings in uptimerobot#171744
Merged
frenck merged 4 commits intoMay 22, 2026
Merged
Conversation
home-assistant
Bot
added
bugfix
cla-signed
has-tests
integration: uptimerobot
small-pr
Contributor
|
Hey there @ludeeus, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the UptimeRobot integration to use translated exception metadata (via translation_domain / translation_key) instead of hardcoded exception strings, and adjusts tests accordingly.
Changes:
- Add new exception message keys under
exceptionsinhomeassistant/components/uptimerobot/strings.json. - Raise
ConfigEntryAuthFailed/UpdateFailedusing translation metadata in the coordinator and setup entry. - Update the setup/reauth test to assert the new (translated) config entry failure reason.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
homeassistant/components/uptimerobot/coordinator.py |
Switches auth/update exceptions to translated exceptions; currently introduces a misleading translation key/placeholder for update failures. |
homeassistant/components/uptimerobot/__init__.py |
Switches wrong-API-key-type setup failure to translated exception metadata. |
homeassistant/components/uptimerobot/strings.json |
Adds new exceptions.* messages used by the translated exceptions. |
tests/components/uptimerobot/test_init.py |
Updates assertions to match the new auth-failure reason text. |
Comment on lines
+58
to
+62
| raise UpdateFailed( | ||
| translation_domain=DOMAIN, | ||
| translation_key="api_exception", | ||
| translation_placeholders={"error": "Generic UptimeRobot exception"}, | ||
| ) from exception |
joostlek
approved these changes
May 21, 2026
joostlek
previously requested changes
May 21, 2026
Member
joostlek
left a comment
joostlek
left a comment
There was a problem hiding this comment.
We can remove the pylint exceptions
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
ludeeus
reviewed
May 21, 2026
| raise UpdateFailed(exception) from exception | ||
| raise UpdateFailed( | ||
| translation_domain=DOMAIN, | ||
| translation_key="api_exception", |
Member
There was a problem hiding this comment.
The string for "api_exception" is specific for turning on/off monitoring; it is not suitable for use here.
| translation_domain=DOMAIN, | ||
| translation_key="api_exception", | ||
| translation_key="api_switch_exception", | ||
| translation_placeholders={"error": "Generic UptimeRobot exception"}, |
| raise UpdateFailed( | ||
| translation_domain=DOMAIN, | ||
| translation_key="api_generic_exception", | ||
| translation_placeholders={"error": "Generic UptimeRobot exception"}, |
Comment on lines
47
to
+51
| assert mock_config_entry.state is ConfigEntryState.SETUP_ERROR | ||
| assert mock_config_entry.reason == "could not authenticate" | ||
| assert ( | ||
| mock_config_entry.reason | ||
| == "API authentication failed, please check your API key" | ||
| ) |
Comment on lines
160
to
164
| assert exc_info.value.translation_domain == "uptimerobot" | ||
| assert exc_info.value.translation_key == "api_exception" | ||
| assert exc_info.value.translation_key == "api_switch_exception" | ||
| assert exc_info.value.translation_placeholders == { | ||
| "error": "Generic UptimeRobot exception" | ||
| } |
Comment on lines
188
to
192
| assert exc_info.value.translation_domain == "uptimerobot" | ||
| assert exc_info.value.translation_key == "api_exception" | ||
| assert exc_info.value.translation_key == "api_switch_exception" | ||
| assert exc_info.value.translation_placeholders == { | ||
| "error": "Generic UptimeRobot exception" | ||
| } |
frenck
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix hardcoded exception strings in uptimerobot, found in home-assistant/epics#71
Note: Used the same message already used in the integration. Will need a tweak in future: home-assistant/architecture#1397
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: