Skip to content

S28 5057 add suffix to rtmps link#1513

Merged
lydiaralphgov merged 3 commits into
masterfrom
demo
Jul 8, 2026
Merged

S28 5057 add suffix to rtmps link#1513
lydiaralphgov merged 3 commits into
masterfrom
demo

Conversation

@lydiaralphgov

Copy link
Copy Markdown
Contributor

Re-opened #1507 after demo was overwritten by merge to master.

Important

This PR requires small changes on Power Automate, sds-flux-config and CVP before it will work

JIRA ticket(s)

Change description

  • Adds a suffix to the RTMPS link returned to Power Platform
  • This means that the court clerk will not need to manually enter reference details

CVP change

This reference details box needs to be turned off in rooms which are being used for recordings on environments where this new code is deployed.

image

To make it ready for testing

  1. https://make.powerautomate.com
  2. App_API_AMS_CreateAndStartLiveEvent
  3. Find the step called "Set variable - rtmpAddress" near the bottom
  4. Change it from body/input_rtmp to body/displayed_rtmps_link
  • Update Streaming Manager app to point to updated data source
  • Update Streaming Manager flows to point to updated flow

QA instructions

Test 1: Demo is not broken when flag is false and CVP is unchanged

  1. Ask CVP to enable CVP reference details box
  2. Ensure the RTMPS_SUFFIX_ENABLED flag is false on Demo (i.e. don't merge the flux config PR yet)
  3. Schedule a recording as normal
  4. Click 'Start recording'
  5. Assert that the RTMPS link does not have a suffix (i.e. has not changed)
  6. Copy and paste the RTMPS link into the CVP room as normal (with the CVP change not implemented)
  7. Assert that the recording is successful

Test 2: Demo is not broken when flag is true and CVP have turned off reference details box

  1. Ask CVP to disable CVP reference details box
  2. Ensure the RTMPS_SUFFIX_ENABLED flag is true on Demo (i.e. merge the flux config PR)
  3. Schedule a recording as normal
  4. Click 'Start recording'
  5. Assert no CVP reference details box appears
  6. Assert that the RTMPS link does have a suffix (i.e. has changed)
  7. Copy and paste the RTMPS link into the CVP room as normal
  8. Assert that the recording is successful

Test 3: RTMPS link continues to have suffix when the user re-requests the RTMPS link

  1. After starting a recording, navigate back to the Live Screen view
  2. Click 'Show Link'
  3. The RTMPS link should match the previous RTMPS link from when the recording was first started

Release instructions

  1. Merge code into master branch and promote to prod: this is not a breaking change
  2. Alter Power Automate flow on all envs: this is not a breaking change and can be done after step 1
  3. Ask CVP to turn off the reference details box on all CVP rooms - this is a breaking change
  4. Enable the RTMPS_SUFFIX_ENABLED flag - must be done straight after the CVP change

lydiaralphgov and others added 3 commits July 8, 2026 14:28
Co-authored-by: PRE DevOps <138598290+pre-devops@users.noreply.github.com>
Co-authored-by: PRE DevOps <138598290+pre-devops@users.noreply.github.com>
@lydiaralphgov lydiaralphgov changed the title Demo S28 5057 add suffix to rtmps link Jul 8, 2026
@lydiaralphgov lydiaralphgov marked this pull request as ready for review July 8, 2026 15:44
@lydiaralphgov lydiaralphgov requested a review from a team as a code owner July 8, 2026 15:44
@lydiaralphgov lydiaralphgov merged commit 94dc361 into master Jul 8, 2026
8 checks passed
@lydiaralphgov lydiaralphgov deleted the demo branch July 8, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants