Skip to content

Pass Redis port as an environment variable #4864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adamg-hmcts wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Pass Redis port as an environment variable #4864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
86484bd
Pass Redis port as an environment variable
adamg-hmcts Jul 8, 2026
4be2aee
Merge branch 'master' into nfdiv-5659-move-redis-port-into-env-variable
adamg-hmcts Jul 8, 2026
09b41cc
Bumping chart version/ fixing aliases
hmcts-jenkins-j-to-z[bot] Jul 8, 2026
f712d60
Merge branch 'master' into nfdiv-5659-move-redis-port-into-env-variable
adamg-hmcts Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/nfdiv-frontend/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: '1.0'
description: A Helm chart for nfdiv-frontend App
name: nfdiv-frontend
home: https://github.com/hmcts/nfdiv-frontend
version: 0.0.114
version: 0.0.115
dependencies:
- name: nodejs
version: 3.2.1
Expand Down
1 change: 1 addition & 0 deletions charts/nfdiv-frontend/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ nodejs:
PAYMENTS_API_URL: 'http://payment-api-{{ .Values.global.environment }}.service.core-compute-{{ .Values.global.environment }}.internal'
FEES_API_URL: 'http://fees-register-api-{{ .Values.global.environment }}.service.core-compute-{{ .Values.global.environment }}.internal'
REDIS_HOST: 'nfdiv-frontend-{{ .Values.global.environment }}.redis.cache.windows.net'
REDIS_PORT: 6380
CCD_URL: 'http://ccd-data-store-api-{{ .Values.global.environment }}.service.core-compute-{{ .Values.global.environment }}.internal'
#CCD_URL: 'https://nfdiv-case-api-pr-3980.preview.platform.hmcts.net'
#SKIP_DIV_CASE_CHECK: false #this is required to connect to nfdiv-case-api in preview
Expand Down
1 change: 1 addition & 0 deletions config/custom-environment-variables.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ port: PORT
session:
redis:
host: REDIS_HOST
port: REDIS_PORT
appInsights:
instrumentationKey: APPINSIGHTS_KEY
launchDarkly:
Expand Down
3 changes: 2 additions & 1 deletion config/default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ session:
maxAge: 1260000
redis:
host:
port: 6380
key:
e2e:
userTestPassword: ''
Expand Down Expand Up @@ -128,4 +129,4 @@ govukUrls:
getHelpWithCourtFeesCY: 'https://www.gov.uk/help-i-dalu-ffioedd-llysoedd-a-thribiwnlysoedd'
certifiedTranslation: 'https://www.gov.uk/certifying-a-document#certifying-a-translation'
searchForDecreeAbsoluteOrFinalOrder: 'https://www.gov.uk/copy-decree-absolute-final-order/do-not-know-which-court'
serviceOfDocuments: 'https://www.gov.uk/guidance/service-of-documents-and-taking-of-evidence'
serviceOfDocuments: 'https://www.gov.uk/guidance/service-of-documents-and-taking-of-evidence'
4 changes: 3 additions & 1 deletion src/main/modules/session/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,13 @@ export class SessionStorage {

private getStore(app: Application, logger: Logger) {
const redisHost = config.get('session.redis.host');
const redisPort = config.get('session.redis.port');

if (redisHost) {
const client = redis.createClient({
socket: {
host: redisHost as string,
port: 6380,
port: redisPort as number,
connectTimeout: 15000,
tls: true,
},
Expand Down