perf: change passthrough compressor to avoid allocation#249
Open
mikhailofff wants to merge 1 commit intohit-box:mainfrom
Open
perf: change passthrough compressor to avoid allocation#249mikhailofff wants to merge 1 commit intohit-box:mainfrom
mikhailofff wants to merge 1 commit intohit-box:mainfrom
Conversation
Contributor
|
Hi @mikhailofff! Sorry for the late response, and thanks for your PR! |
mikhailofff
force-pushed
the
fix/issue-220
branch
from
d772073 to
9f21e38
Compare
mikhailofff
commented
Mar 24, 2026
Author
mikhailofff
left a comment
mikhailofff
left a comment
There was a problem hiding this comment.
Hi @AndreyErmilov. Thanks for your review. I hope all is good now.
Contributor
|
Thank you! I ran the CI and there are a few errors there. Take a look at them please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compress(&[u8]) -> Vectocompress(&[u8]) -> Cow<[u8]>so passthrough compressor avoids allocation.decompress(&[u8]) -> Vectodecompress(&[u8]) -> Cow<[u8]>as well.Closes #220.