fix: count stx mint data at block 0 towards account balances#2289
Merged
fix: count stx mint data at block 0 towards account balances#2289
Conversation
|
Vercel deployment URL: https://stacks-blockchain-2vh04jyaj-hirosystems.vercel.app 🚀 |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
rafaelcr
changed the title
hirosystems-release-bot Bot
added a commit
that referenced
this pull request
May 26, 2025
## [8.11.0](v8.10.0...v8.11.0) (2025-05-26) ### Features * add /extended/v2/block-tenures/:height/blocks endpoint ([#2285](#2285)) ([f5c2e01](f5c2e01)) * stacks core event and rpc proxy body limits configurable via env ([#2278](#2278)) ([8a54e9d](8a54e9d)) * store and expose vm_error for failed transactions ([#2286](#2286)) ([7ac7513](7ac7513)) ### Bug Fixes * consider microblock transactions in balance calculations ([#2277](#2277)) ([3418863](3418863)) * count stx mint data at block 0 towards account balances ([#2289](#2289)) ([a0cd9f2](a0cd9f2)) * ignore unanchored param for BNS names endpoint ([#2263](#2263)) ([3d33725](3d33725)) * keep a table of latest stacks node event timestamps ([#2266](#2266)) ([6f111ad](6f111ad)) * module imports in block tenure routes ([#2287](#2287)) ([2cb442e](2cb442e)) * **rosetta:** get current block should only join by stacks chain tip information ([#2265](#2265)) ([78ebad0](78ebad0)) * simplify transaction events query ([#2279](#2279)) ([517ca68](517ca68))
Contributor
|
🎉 This PR is included in version 8.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our
chain_tiptable starts withblock_heightat zero, so when the API received the block 0 boot data from the Stacks node it is always marked as non-canonical.This affected FT balance calculations because STX mint events contained within were not being considered, especially in devnet or testnet deployments where devs were configuring
[[ustx_balance]]settings in their Stacks nodes.This PR makes it so block 0 STX mint data is always considered for balances.
Related to #2267