feat(themes): add built-in theme support for overlay - #66
Open
hikaps wants to merge 2 commits into
Open
Conversation
added 2 commits
August 4, 2026 14:39
Extract all hardcoded overlay colors into semantic brush keys in a
compiled ResourceDictionary and add four built-in themes (Default,
Light, Minimal, Vibrant) selectable in settings.
- Add ThemeManager to resolve/apply theme dictionaries at window
creation (before InitializeComponent so DynamicResource resolves)
- Convert ~77 inline color sites in OverlayWindow.xaml to
{DynamicResource} references
- Replace code-behind hardcoded brushes (section focus, achievement
text, shortcut button factory) with themed lookups
- Add ThemeName setting + Appearance group box in settings view
- Add tests: theme name resolution, XAML key coverage vs Default,
key-set consistency across all themes
Closes #54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds theming support to the overlay (issue #54, v1: built-in themes). All hardcoded overlay colors are extracted into a semantic brush-key ResourceDictionary, and four built-in themes are selectable in settings.
Changes
Themes/Default.xaml— the current dark appearance, as semantic brush keysThemes/Light.xaml— light surfaces/dark textThemes/Minimal.xaml— near-monochrome with muted accentsThemes/Vibrant.xaml— saturated cyan/purple/red accents on blue-tinted darkThemes/ThemeManager.cs— resolves theme names (case-insensitive, fallback to Default), loads compiled dictionaries via pack URI, applies to window beforeInitializeComponent, resolves brushes for code-behind useOverlayWindow.xaml— ~77 inline color sites converted to{DynamicResource}references (surfaces, text tiers, focus borders, all three accent families with hover/pressed variants)OverlayWindow.xaml.cs— theme applied in constructor; hardcoded brushes (section focus highlight, achievement gold/muted text, shortcut button factory) replaced with themed lookups; newthemeNameconstructor paramOverlaySettings.cs/OverlaySettingsView.xaml/OverlaySettingsViewModel.cs—ThemeNamesetting, Appearance group box with theme combo, validation against built-in theme listOverlayService.cs— passes the selected theme into the windowtests/ThemeManagerTests.cs— name resolution, XAML key coverage vs Default, key-set consistency across all themesDesign
DynamicResource(notStaticResource) so themes can be swapped at runtime without re-creating the window./OverlayPlugin;component/Themes/{Name}.xaml.Testing
ResolveThemeNamenormalization, every{DynamicResource}key inOverlayWindow.xamlexists in Default, all four theme dictionaries define the identical key set.Closes #54