[4.5] Add ReactiveSelectionQuery.getKeyedResultList - #4073
Draft
dreab8 wants to merge 2 commits into
Draft
Conversation
DavideD
changed the title
Documentation PreviewDocumentation preview artifact not found for commit a0e2aac. View workflow run for details. |
DavideD
requested changes
Aug 12, 2026
DavideD
left a comment
DavideD
left a comment
Member
There was a problem hiding this comment.
Looks good overall, but I think we need to have the new methods in the Mutiny.SelectionQuery and Stage.SelectionQuery interfaces.
Not critical, but I would also add a test to see what happens when there are no results from the query (just in case). And that we throw the exception for Native queries.
Thanks
dreab8
force-pushed
the
issue#3811
branch
2 times, most recently
from
August 12, 2026 12:07
ad7da8f to
bcb81ad
Compare
DavideD
requested changes
Aug 12, 2026
DavideD
left a comment
DavideD
left a comment
Member
There was a problem hiding this comment.
LGTM, but you need add some tests
dreab8
force-pushed
the
issue#3811
branch
2 times, most recently
from
August 12, 2026 14:08
93cc74f to
a411579
Compare
Member
|
In the meanwhile, I merged these changes in |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #3811
It needs the following changes in ORM hibernate/hibernate-orm#13180