fix(virtqueue): Fix usage of unaligned values in Vring<_>#1024
Conversation
|
I much appreciate your effort, but So I can review this one, but in general I'd suggest ignoring the virtqueue parts for the moment. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1024 +/- ##
==========================================
- Coverage 74.21% 73.88% -0.33%
==========================================
Files 28 28
Lines 3141 3155 +14
==========================================
Hits 2331 2331
- Misses 810 824 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Note that the new code has similar issues, albeit I'm surprised to see |
|
Afaik there's no |
This attempts to tackle the first issue raised in #571.
Personally, I would prefer it if
Vringwouldn't store a simple pointer in the first place, but at least a&mut [u8]slice, such that it can catch cases where the access would go out of bounds, but that would require messing withvirtio.rs, which I didn't dare to touch yet.