ci: use commit message as promotion PR title and body#36
Merged
Conversation
The promote workflow wrote a generic one-line body that gave upstream maintainers no context. Derive the PR title from the commit subject and the body from the commit message body (leading blank lines stripped), and refresh an already-open PR via gh pr edit instead of skipping, so a re-run repairs an existing promotion PR's description.
Automated PR ReviewModel: Changed files: Review result: No automated findings were found. The workflow changes appear to safely quote user/commit-derived values and preserve the existing idempotent behavior while updating PR metadata. Residual risks include operational edge cases around manual branch input validity and the PAT/environment protection configuration, which are outside the diff’s direct correctness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
promote-upstream.ymlnow derives the upstream PR title from the commit subject and the body from the commit message body (leading blank lines stripped), instead of a generic one-line placeholder that gave maintainers no context.Also: when an open PR from the branch already exists, the job now refreshes it via
gh pr editrather than skipping — so re-running the workflow repairs the description of an already-open promotion PR (e.g. plmbr#386).Why
The first promotion opened a PR whose body was just "Automated promotion … after review sign-off." — useless to upstream reviewers. The security fix commit already documents the vulnerability, attack path, and fix rationale; that content should be the PR body.
Effect
Re-dispatching Promote to upstream for
security/fix-search-files-symlink-20260704031032-3406will update the open upstream PR's body to the full commit message.Generated by Claude Code