Working build on Windows (SSH/custom repo)

[etinin]

On VS2019 the packages won't build and, even with the mistakes fixed, without some changes it is not possible to connect through SSH to custom repos. (at least on my machine with git, ssh, etc already installed). So I figured a general solution:

Copy newest Git (used x64 over here) instead of msysgit to msysgit folder and then overwrite the SSH files with portable ones built for windows.

Fixed some minor coding mistakes.
The HOME variable shouldn't be set, else problems will arise.
Instead, a portable version of OpenSSH should be used : https://github.com/PowerShell/openssh-portable

(I guess this could be automated with a script, but I just wanted to get it working and figured out the steps, in case it interests anybody else).

Will build and produce a working "portable" package. Did not attempt to build the installer.

#1909 #1924 #1923 #1781 #1888

[hbons]

This is great. Thank you! :)

I'm happy to merge this, but I don't want to have binary files in the repo if it can be avoided. Can you adjust the build script to download and verify msysgit from a trusted source? This is what happens in the Mac project as well.

[etinin]

This is great. Thank you! :)

I'm happy to merge this, but I don't want to have binary files in the repo if it can be avoided. Can you adjust the build script to download and verify msysgit from a trusted source? This is what happens in the Mac project as well.

yes, I think that's the optimal solution! I'll try to get to it as soon as possible