feat: expose address type - #2010
Open
wiomoc wants to merge 1 commit into
Open
Conversation
wiomoc
force-pushed
the
feat/expose-address-type
branch
from
July 3, 2026 23:16
a032ccb to
1883d89
Compare
wiomoc
marked this pull request as ready for review
July 3, 2026 23:23
wiomoc
force-pushed
the
feat/expose-address-type
branch
from
July 3, 2026 23:56
1883d89 to
77dfa2b
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2010 +/- ##
===========================================
- Coverage 53.00% 52.71% -0.29%
===========================================
Files 43 43
Lines 4094 4137 +43
Branches 504 513 +9
===========================================
+ Hits 2170 2181 +11
- Misses 1792 1822 +30
- Partials 132 134 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Collaborator
|
Thanks. A bit of feedback:
|
wiomoc
force-pushed
the
feat/expose-address-type
branch
2 times, most recently
from
July 5, 2026 19:36
ad9700a to
552cdfb
Compare
wiomoc
force-pushed
the
feat/expose-address-type
branch
from
July 6, 2026 09:52
552cdfb to
b5d13ff
Compare
Author
|
I've followed your feedback up to the integration tests, since I wasn't able to get them to run locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1414
Motivation: on linux connecting to a ble peripheral via a l2cap socket requires you to specify the address type (
l2_bdaddr_type).Tested on Linux with bluez 5.82 and Windows 11
Untested on Android