Add Host header and frame response body in TcpClient#150
Merged
kevinresol merged 1 commit intoJul 13, 2026
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TcpClientnever sent aHostheader (mandatory for HTTP/1.1, RFC 7230 §5.4) and returned the raw connection source as the response body without any framing.Hostheader when the request does not already have one, including the port when it is non-default for the scheme (e.g.example.com:8080).SocketClient: chunkedTransfer-Encoding(case-insensitive) →Chunked.decode, elseContent-Length→ limit, else read until the connection closes.Connection reuse is intentionally left out of scope (the connection is still closed after each request).
Made with Cursor