Skip to content

ETT-1394 address warning: "CGI::Param called in list context"#234

Draft
moseshll wants to merge 5 commits into
mainfrom
ETT-1394_cgi_param_list_context
Draft

ETT-1394 address warning: "CGI::Param called in list context"#234
moseshll wants to merge 5 commits into
mainfrom
ETT-1394_cgi_param_list_context

Conversation

@moseshll

@moseshll moseshll commented Jun 26, 2026

Copy link
Copy Markdown
Contributor
  • Include mb/t/ in perl-test

  • Address and test LS::PIFiller::ListSearchResults::handle_ANALYTICS_REPORT_URL_PI

  • Address and test MBooks::PIFiller::ListUtils::handle_ANALYTICS_REPORT_URL_PI

  • Address issue in MBooks::Operation::LogoutTrap::redirect_and_exit

    • Not really testable for reasons cited in ticket:

    Perl gets mad at the exit call and complains “A context appears to have been destroyed without first calling release…” with a half page of noise.

    • The function in question calls exit and it appears its call to MBooks::View::P_redirect_HTTP also calls exit.
  • Address issue in PT::Prolog::Run

    • No tests because the method is enormous and the prospect of scaffolding a unit test is daunting.

There are no other issues flagged in the error logs I could find in the past 30 days.

moseshll added 5 commits June 26, 2026 16:45
  - Fix and tests for `handle_ANALYTICS_REPORT_URL_PI`
- Not really testable for reasons cited in ticket
- No tests because the method is enormous and the prospect of scaffolding a unit test is daunting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant