ETT-1394 address warning: "CGI::Param called in list context"#234
Draft
moseshll wants to merge 5 commits into
Draft
ETT-1394 address warning: "CGI::Param called in list context"#234moseshll wants to merge 5 commits into
moseshll wants to merge 5 commits into
Conversation
- Include `mb/t/` in `perl-test`
- Fix and tests for `handle_ANALYTICS_REPORT_URL_PI`
…LYTICS_REPORT_URL_PI`
- Not really testable for reasons cited in ticket
- No tests because the method is enormous and the prospect of scaffolding a unit test is daunting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include
mb/t/inperl-testAddress and test
LS::PIFiller::ListSearchResults::handle_ANALYTICS_REPORT_URL_PIAddress and test
MBooks::PIFiller::ListUtils::handle_ANALYTICS_REPORT_URL_PIAddress issue in
MBooks::Operation::LogoutTrap::redirect_and_exitexitand it appears its call toMBooks::View::P_redirect_HTTPalso callsexit.Address issue in
PT::Prolog::RunThere are no other issues flagged in the error logs I could find in the past 30 days.