fix: project list/search openInHarness URLs (org alias, nested project rows)#104
Draft
thisrohangupta wants to merge 1 commit into
Draft
fix: project list/search openInHarness URLs (org alias, nested project rows)#104thisrohangupta wants to merge 1 commit into
thisrohangupta wants to merge 1 commit into
Conversation
- Alias orgIdentifier/projectIdentifier to org/project for templates - Avoid String() on nested API objects (prevents [object Object] in URLs) - Add regression tests for nested project rows and flat identifiers Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes malformed
openInHarnesslinks forharness_list/ search onresource_type: project.Root cause
deepLinkTemplateuses{org}and{project}, but the registry only populatedorgIdentifierandprojectIdentifierfrom the request scope, so{org}was left literal in the URL.project: { identifier, name }object led toString(project)→[object Object]in the path when that field was used as a placeholder.Changes
orgIdentifier↔organdprojectIdentifier↔projectso short template names resolve.scalarForDeepLinkhelper so only string/number/boolean values become placeholders; nested objects fall through to nested unwrapping instead ofString(object).identifierrows.Type of Change
Checklist
pnpm test tests/registry/registry.test.tsandpnpm typechecklocally)Slack Thread