Add GMGPolar as a possible IPolarPoissonLikeSolver by EmilyBourne · Pull Request #644 · gyselax/gyselalibxx

EmilyBourne · 2026-04-21T12:56:25Z

Add GMGPolar as a possible IPolarPoissonLikeSolver.

SciCompMod/GMGPolar#214 should be merged before merging this PR

Please complete the checklist to ensure that all tasks are completed before marking your pull request as ready for review.

All Submissions

Have you ensured that all lines changed in this PR are justified by a comment found in the description ?
Have you updated the CHANGELOG.md ?
Have you linked any issues that should be closed when this PR is merged (using closing keywords) ?
Have you checked that the AUTHORS file is up to date ?
Have you checked that the copyright information in the LICENCE file is up to date (including dates) ?
Do you follow the conventions specified in our coding standards ?

New Feature Submissions

Have you added tests for the new functionalities ?
Have you documented the new functionalities:
- API documentation describing the available methods, when each should be used and how to use them ?
- User-friendly documentation in README files (which may link to the API documentation).
- If the new functionality is non-trivial to use, provide a tutorial or example ? (optional)

Changes to Existing Features

Have you checked that existing tests cover all code after the changes ?
Have you checked that existing tests are still passing ?
Have you checked that the existing documentation is still accurate (API and README files) ?

Changes to the CI

Have you made the same changes to both the GitHub CI and the GitLab CI (for the private fork) ?

github-actions · 2026-04-21T12:59:45Z

This PR is failing tests so it has been put back into draft. Please remove the draft status when the tests pass.

github-actions · 2026-04-21T14:00:07Z

This PR is failing tests so it has been put back into draft. Please remove the draft status when the tests pass.

codecov · 2026-04-21T15:47:29Z

Codecov Report

❌ Patch coverage is 92.20779% with 6 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/pde_solvers/gmg_polar_poisson_like_solver.hpp	92.20%	6 Missing ⚠️

📢 Thoughts on this report? Let us know!

tpadioleau · 2026-04-21T16:23:58Z

+set(GMGPOLAR_BUILD_TESTS OFF CACHE BOOL "")
+add_subdirectory("vendor/GMGPolar/" "GMGPolar" EXCLUDE_FROM_ALL SYSTEM)
+# Suppress -Werror=unused-variable inherited via CMAKE_CXX_FLAGS_INIT so that GMGPolar warnings don't break the build.
+target_compile_options(GMGPolarLib PRIVATE -Wno-error=unused-variable)


Another reason I don't like vendoring :)

tpadioleau · 2026-04-21T16:24:52Z

 find_package(Ginkgo 1.8 REQUIRED)

+set(GMGPOLAR_BUILD_TESTS OFF CACHE BOOL "")
+add_subdirectory("vendor/GMGPolar/" "GMGPolar" EXCLUDE_FROM_ALL SYSTEM)


Suggested change

add_subdirectory("vendor/GMGPolar/" "GMGPolar" EXCLUDE_FROM_ALL SYSTEM)

add_subdirectory(vendor/GMGPolar EXCLUDE_FROM_ALL SYSTEM)

Do we have a reason to exclude from all ?

I don't want to compile the executables or the test/interface library. I am only interested in one library from the folder (GMGPolarLib)

Is there a reason to not use EXCLUDE_FROM_ALL?
It doesn't stop anything from being compiled it just ensures that the only things that are compiled are the libs that are used

tpadioleau · 2026-04-21T16:25:18Z


 find_package(Ginkgo 1.8 REQUIRED)

+set(GMGPOLAR_BUILD_TESTS OFF CACHE BOOL "")


One reason I don't like vendoring

Actually maybe we don't need this if we're using EXCLUDE_FROM_ALL 🤔

tpadioleau · 2026-04-21T16:25:54Z

        gslx::data_types
        gslx::matrix_tools
        gslx::utils
+        GMGPolarLib


We should push for an alias before merging.

This is why I asked for your opinion on the CMake PR on the GMGPolar side

tpadioleau · 2026-04-21T16:46:56Z

        gslx::data_types
        gslx::matrix_tools
        gslx::utils
+        GMGPolarLib


Suggested change

GMGPolarLib

GMGPolar::GMGPolarLib

Co-authored-by: Thomas Padioleau <thomas.padioleau@cea.fr>

github-actions · 2026-04-22T08:55:47Z

This PR is failing tests so it has been put back into draft. Please remove the draft status when the tests pass.

EmilyBourne added 10 commits April 20, 2026 11:53

Add GMGPolar to submodules

aabef89

Add a GMGPolarPoissonLikeSolver class

8fe0eeb

More readable filename

7da47e5

Inheritance

0620e89

Update GMGPolar version

d1ac613

Add a test

ef6791c

Fix Werror failures

20b1efd

Tidy up class

874169c

Pin to GMGPolar version with CMake fixes

2e8e6e3

CHANGELOG

962cad5

EmilyBourne added the Do not merge Label for a PR that should not be merged even if it appears to be ready label Apr 21, 2026

Merge branch 'devel' into ebourne_gmgpolar

9e099b6

github-actions Bot marked this pull request as draft April 21, 2026 12:59

EmilyBourne added 3 commits April 21, 2026 15:21

Docs

6038fbf

Basic methods can be static

30bb98d

Docs

3252104

EmilyBourne marked this pull request as ready for review April 21, 2026 13:50

EmilyBourne had a problem deploying to GitLab GPU trigger April 21, 2026 13:51 — with GitHub Actions Error

github-actions Bot marked this pull request as draft April 21, 2026 14:00

EmilyBourne added 2 commits April 21, 2026 16:10

Missing double

8d875ee

Merge branch 'devel' into ebourne_gmgpolar

a350572

EmilyBourne marked this pull request as ready for review April 21, 2026 15:24

EmilyBourne temporarily deployed to GitLab GPU trigger April 21, 2026 15:25 — with GitHub Actions Inactive

github-actions Bot added the Ready to review Label to be automatically added to a PR when it is ready to be reviewed label Apr 21, 2026

tpadioleau requested changes Apr 21, 2026

View reviewed changes

github-actions Bot removed the Ready to review Label to be automatically added to a PR when it is ready to be reviewed label Apr 21, 2026

github-actions Bot marked this pull request as draft April 21, 2026 16:26

tpadioleau reviewed Apr 21, 2026

View reviewed changes

EmilyBourne and others added 5 commits April 22, 2026 09:30

Update GMGPolar

1abed13

Use aliased target

4c7b150

Merge branch 'devel' into ebourne_gmgpolar

5c0bb1a

Don't move GMGPolar to a non-vendor folder

1c3770f

Co-authored-by: Thomas Padioleau <thomas.padioleau@cea.fr>

Merge branch 'devel' into ebourne_gmgpolar

a68bc29

EmilyBourne marked this pull request as ready for review April 22, 2026 08:54

github-actions Bot marked this pull request as draft April 22, 2026 08:55

Update GMGPolar

0289b2f

EmilyBourne marked this pull request as ready for review April 22, 2026 09:05

EmilyBourne had a problem deploying to GitLab GPU trigger April 22, 2026 09:06 — with GitHub Actions Failure

github-actions Bot added the Ready to review Label to be automatically added to a PR when it is ready to be reviewed label Apr 22, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add GMGPolar as a possible IPolarPoissonLikeSolver#644

Add GMGPolar as a possible IPolarPoissonLikeSolver#644
EmilyBourne wants to merge 22 commits into
develfrom
ebourne_gmgpolar

EmilyBourne commented Apr 21, 2026

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

codecov Bot commented Apr 21, 2026 •

edited

Loading

Uh oh!

tpadioleau Apr 21, 2026

Uh oh!

tpadioleau Apr 21, 2026

Uh oh!

EmilyBourne Apr 21, 2026

Uh oh!

tpadioleau Apr 21, 2026

Uh oh!

EmilyBourne Apr 22, 2026

Uh oh!

tpadioleau Apr 21, 2026

Uh oh!

EmilyBourne Apr 21, 2026

Uh oh!

tpadioleau Apr 21, 2026

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	add_subdirectory("vendor/GMGPolar/" "GMGPolar" EXCLUDE_FROM_ALL SYSTEM)
	add_subdirectory(vendor/GMGPolar EXCLUDE_FROM_ALL SYSTEM)


		find_package(Ginkgo 1.8 REQUIRED)

		set(GMGPOLAR_BUILD_TESTS OFF CACHE BOOL "")

Conversation

EmilyBourne commented Apr 21, 2026

All Submissions

New Feature Submissions

Changes to Existing Features

Changes to the CI

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

codecov Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Apr 21, 2026 •

edited

Loading