Choose todo archive based on todo name#2755
Open
kw217 wants to merge 1 commit intogsantner:masterfrom
Open
Conversation
kw217
force-pushed
the
derive-todo-archive-name
branch
from
104f492 to
6a3a910
Compare
Author
|
Hi @gsantner - is this a reasonable approach? Do you need me to do anything before you review? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier to use multiple .todo.txt files, by making the archive function pick a name for the archive based on the name of the todo file. If the todo file is
foo.todo.txt, the proposed archive will be.foo.todo.archive.txt. For the defaulttodo.txtit is.todo.archive.txt. This is just the default in the dialog - it is still possible to choose any name you like. The name is still remembered for each file.The suggested default starts with a
.to avoid clutter - this hides the archive file. I considered adding a setting to allow you to change this behaviour, but it seemed unnecessary clutter. Let me know if you think that would be useful and I will add it.Let me know if there are any documents or tests I should update.
Thanks!