Fix webview jumping by harshad1 · Pull Request #2736 · gsantner/markor

harshad1 · 2026-02-16T06:01:46Z

This Addresses #2726

In addition I have included a number of general fixes and improvements

Fix DocumentEditAndViewFragment layout so that they sit on top of the action bar properly
Remove the close button for the new search layout. Pressing the search button again closes the search view
Eliminate the need for searchText and neutralButtonCallback2 - we already had mechanisms to do what was needed
Fix how dialogs resize when keyboard is shown. Should be much more consistent now
Debouncing filtering only triggered when there are over 1000 lines. Otherwise it is synchronous
Re-enable long-press handling in searchable/custom text dialogs.
Adjust selection reveal offsets so selected text scrolls into a better visible position.
Avoid saving “share as link” preference when the share-into link checkbox is unavailable or hidden.
Keep navigation bar icon contrast in sync with navigation bar color on Android O and newer.

gsantner · 2026-03-06T18:52:19Z

Thank you @harshad1 !
Unfortunate there were merge conflicts added by merging the bigger search PR

gsantner · 2026-03-19T07:44:20Z

Hence can't be merged

harshad1 · 2026-04-07T06:02:34Z

fixed the conflict
fixed system navigation bar contrast
fixed document fragment layout (no 12dp padding needed now)

This is ready for review and merge

harshad1 · 2026-04-08T04:57:39Z

app/src/main/java/net/gsantner/opoc/frontend/GsSearchOrCustomTextDialog.java

            });

-            // listView.setOnItemLongClickListener((parent, view, pos, id) -> directActivate.callback(pos, true));
+            listView.setOnItemLongClickListener((parent, view, pos, id) -> directActivate.callback(pos, true));


@guanglinn It looks like this was disabled accidentally by an earlier PR. Re-enabling it.

I don't think this breaks anything else

harshad1 · 2026-04-13T03:32:56Z

app/src/main/java/net/gsantner/opoc/frontend/GsSearchOrCustomTextDialog.java

        searchEditText.setTextColor(dopt.textColor);
        searchEditText.setHintTextColor(ColorUtils.setAlphaComponent(dopt.textColor, 0x99));
        searchEditText.setHint(dopt.searchHintText);
-        searchEditText.setText(dopt.searchText);


we do not need a separate searchText

dopt.state.searchText does exactly this already

harshad1 · 2026-04-13T03:33:41Z

app/src/main/java/net/gsantner/opoc/util/GsContextUtils.java

                    final Window window = context.getWindow();
                    window.addFlags(WindowManager.LayoutParams.FLAG_DRAWS_SYSTEM_BAR_BACKGROUNDS);
                    window.setNavigationBarColor(color);
+                    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {


Maintain system navigation bar contrast correctly even if markor and device themes mismatch

harshad1 · 2026-04-13T03:33:59Z

app/src/main/res/layout/document__fragment__edit.xml


-        <net.gsantner.markor.frontend.DraggableScrollbarScrollView
-            android:id="@+id/document__fragment__edit__content_editor__scrolling_parent"
+        <FrameLayout


Improved layout eliminates need for extra padding

harshad1 · 2026-04-13T03:35:10Z

app/src/main/res/layout/text_search_fragment.xml

            app:layout_constraintStart_toStartOf="parent"
            app:layout_constraintTop_toTopOf="parent">

-            <ImageButton


@guanglinn I removed the close button and made it so pressing the search icon again closes the view

Let me know if you think this is not clean. I can revert it

No need to revert it I think. The screen space of mobile devices is precious, there is nothing wrong with removing it

harshad1 · 2026-04-13T03:35:47Z

app/src/main/java/net/gsantner/opoc/frontend/GsSearchOrCustomTextDialog.java

+            listAdapter.filter(searchEditText.getText());
+            setSelectAllButtonState.callback();
+        };
+        final Runnable _changeListener = dopt.data == null || dopt.data.size() < 1000 ?


Only debounce when the list is very long

harshad1 · 2026-04-13T03:36:35Z

app/src/main/java/net/gsantner/opoc/frontend/GsSearchOrCustomTextDialog.java

+
+            final View decorView = win.getDecorView();
+            ViewCompat.setOnApplyWindowInsetsListener(decorView, (view, insets) -> {
+                listView.requestLayout();


Explicitly request layout when keyboard shown. Fixes resize

harshad1 · 2026-04-13T03:40:04Z

app/src/main/java/net/gsantner/markor/frontend/MarkorDialogFactory.java

    }

+    @Nullable
+    private static Editable getCurrentSearchText(final AlertDialog dialog) {


@guanglinn instead of neutralButtonCallback2 we fetch the search text from the existing dialog

Okay, I see

harshad1 added 2 commits February 15, 2026 21:50

Fix webview jumping

b043130

hardening

f01475e

gsantner force-pushed the master branch 3 times, most recently from d3c16f5 to c3bd617 Compare March 6, 2026 18:41

gsantner force-pushed the master branch from 96f2a91 to f33eb6a Compare March 19, 2026 08:24

harshad1 added 3 commits April 5, 2026 11:42

Merge remote-tracking branch 'upstream/master' into fix_webview_jumping

96eb6a3

Cleaned up and fixed color

889d4e3

Fixed how document view layout works

4d51bb7

Re-enabled long press

62e1316

harshad1 commented Apr 8, 2026

View reviewed changes

harshad1 mentioned this pull request Apr 8, 2026

Add standard text search and replace #2559

Merged

harshad1 added 5 commits April 8, 2026 09:12

Using state.searchText

56f38a1

Fixed the dialog

e1db27a

Debounce only on large list

90e5056

Merge branch 'master' into fix_webview_jumping

db0f136

Dialogs now resize correctly

d664ddc

harshad1 commented Apr 13, 2026

View reviewed changes

Small tweaks to layout requests in dialog

c00ab80

Conversation

harshad1 commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gsantner commented Mar 6, 2026

Uh oh!

gsantner commented Mar 19, 2026

Uh oh!

harshad1 commented Apr 7, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

harshad1 commented Feb 16, 2026 •

edited

Loading