Skip to content

Interpolable for non conforming octree meshes - #1329

Open
ericneiva wants to merge 3 commits into
masterfrom
interpolable_for_non-conforming_octree_meshes
Open

Interpolable for non conforming octree meshes#1329
ericneiva wants to merge 3 commits into
masterfrom
interpolable_for_non-conforming_octree_meshes

Conversation

@ericneiva

@ericneiva ericneiva commented Jul 31, 2026

Copy link
Copy Markdown
Member

Hello, @JordiManyer and @amartinhuertas,

This PR applies the solution to issue #1269 corresponding to adding an optional vertex_to_cells field to KDTreeSearch to override the default vertex_to_cells when using non-conforming meshes.

I’d rather extract the vertex_to_cells from the triangulation, but this requires, octree meshes to own a non-comforming grid topology.

Lmk if you have any suggestions for improvement. Otherwise, thanks a lot for accepting the PR.

Cheers,
Eric

@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.85%. Comparing base (3f14453) to head (36b6bd6).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1329   +/-   ##
=======================================
  Coverage   88.85%   88.85%           
=======================================
  Files         228      228           
  Lines       30197    30202    +5     
=======================================
+ Hits        26832    26837    +5     
  Misses       3365     3365           
Flag Coverage Δ
drivers 39.36% <0.00%> (-0.01%) ⬇️
extensions 4.99% <0.00%> (-0.01%) ⬇️
unit-adaptivity 39.96% <60.00%> (+<0.01%) ⬆️
unit-basics 14.38% <0.00%> (-0.01%) ⬇️
unit-celldata 20.83% <60.00%> (+<0.01%) ⬆️
unit-fespaces-1 32.63% <100.00%> (+0.01%) ⬆️
unit-fespaces-2 39.32% <60.00%> (+<0.01%) ⬆️
unit-fields 17.45% <0.00%> (-0.01%) ⬇️
unit-geometry 28.35% <0.00%> (-0.01%) ⬇️
unit-multifield 30.42% <60.00%> (+<0.01%) ⬆️
unit-odes 28.30% <0.00%> (-0.01%) ⬇️
unit-referencefes 33.89% <0.00%> (-0.01%) ⬇️
unit-visualization 11.66% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant