Interpolable for non conforming octree meshes - #1329
Open
ericneiva wants to merge 3 commits into
Open
Conversation
… custom point-location connectivity (for non-conforming meshes).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1329 +/- ##
=======================================
Coverage 88.85% 88.85%
=======================================
Files 228 228
Lines 30197 30202 +5
=======================================
+ Hits 26832 26837 +5
Misses 3365 3365
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, @JordiManyer and @amartinhuertas,
This PR applies the solution to issue #1269 corresponding to adding an optional
vertex_to_cellsfield toKDTreeSearchto override the defaultvertex_to_cellswhen using non-conforming meshes.I’d rather extract the
vertex_to_cellsfrom the triangulation, but this requires, octree meshes to own a non-comforming grid topology.Lmk if you have any suggestions for improvement. Otherwise, thanks a lot for accepting the PR.
Cheers,
Eric