fix(fixture): correct variable name in componentWillUnmount#706
Open
everettbu wants to merge 1 commit into
Open
fix(fixture): correct variable name in componentWillUnmount#706everettbu wants to merge 1 commit into
everettbu wants to merge 1 commit into
Conversation
The clearTimeout was using this.interval instead of this.timeout, causing a memory leak where timeouts were never properly cleaned up. Fixes #35814
Greptile SummaryThis PR fixes a one-line bug in the
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: f2e7294 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of facebook/react#36030
Original author: MorikawaSouma
Summary
In \ixtures/attribute-behavior/src/App.js, the \componentWillUnmount\ method had a bug where it checked for \ his.timeout\ but cleared \ his.interval\ (which doesn't exist).
This caused a memory leak where timeouts were never properly cleaned up on component unmount.
Fix
Changed:
\\js
clearTimeout(this.interval);
\\
To:
\\js
clearTimeout(this.timeout);
\\
Test Plan
Fixes #35814