Update HTML parser rules for new select parser#161
Conversation
The HTML spec was updated to remove most special parsing rules for select elements. This PR updates the logic in validateDOMNesting to match the new HTML spec so that authors can use the new parsing rules without getting errors in React. Fixes facebook/react#33609
Greptile OverviewGreptile SummaryUpdated React's DOM nesting validation to align with the HTML spec's removal of special parsing rules for Key changes:
This change enables developers to use modern HTML parsing behavior without validation warnings, as shipped in Chrome and implemented behind a flag in WebKit. Confidence Score: 5/5
Important Files ChangedFile Analysis
|
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
Mirror of facebook/react#34804
Original author: josepharhar
Summary
The HTML spec was updated to remove most special parsing rules for select elements: whatwg/html#10548
Chrome shipped these parser changes a while ago, and they have been implemented behind a flag in WebKit.
This PR updates the logic in validateDOMNesting to match the new HTML spec so that authors can use the new parsing rules without getting errors in React.
Fixes facebook/react#33609
How did you test this change?
I updated the test cases in validateDOMNesting-test.js