-
Notifications
You must be signed in to change notification settings - Fork 2
test: PR for chat with PR testing #15977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
bfaa7be
674e0df
830c55f
e0ed6c6
eb1d2d1
8ae0fd8
9c7d19c
94c44de
947d219
a62e36e
de0950c
3c8ac83
569859d
c73537c
0e6a7ca
17e0a2e
b84d659
78d1aef
17955f2
2bb6114
7bc8bb6
6a6fdcf
893c022
70ef074
41199b8
d19f665
34a771d
02cad7b
2a3fd7e
c3cd021
f07d31b
bc8b70d
fdfe0e6
e74bc05
ebb21ea
ebeb124
2edec42
bd5e778
10e0c97
2b8f624
5cbe42b
e65f70e
b05fec0
8d356c1
f0b9da0
35de591
6ca3141
7233a7a
8f76ff2
8dffaea
03acb59
119afc8
80711ca
9c5756f
dbaeb3f
d462a69
90e8a9c
d8abafb
20d7cf5
6f4b78d
b4cfe02
332049c
9421f3c
be10fe2
86a58a9
cc9e357
9dc3c77
8efa62c
e8cf586
6699288
79a3618
9259dcb
b38a0ef
e2f9fec
4914807
471cdd0
b623f0e
f2e5b6d
7527203
bf116cc
d5e8703
79feaee
8984a96
3450fac
a6dac2f
2aa4834
6cc7404
443de16
4f6cbcb
f6e6f9e
36ba0ae
38e9357
790b7cb
801e92f
24c93f9
29ec7e5
5eb1154
97dc3cc
cd80bd0
6182df2
9da329b
d690175
500cfb7
71ad19b
501b25f
1a4893a
685884f
e0229bb
f39c2e7
c91003d
b2d9086
8879dce
15146ae
ba05148
a9648d0
382be9b
be2b4a9
c6f898a
12d99d6
ce1bcb7
2ff87c3
4bbd85a
b5dfd38
be43fe4
baceff9
b80f90b
5d56750
dd4e092
36faa00
df9d15c
05cc05a
afc5118
7d6a708
5f2ba53
4b7505b
c99cc83
b1a0f81
286d34d
57c3800
0189a55
1020302
b06b5b4
b0191e8
e158679
cf7721c
2081ee0
4089019
c370323
18b39fc
945ddfd
b814336
b90e62d
ac527c2
ca157e9
ef7708a
47f86e4
f9b69d3
8343957
a9d24bb
f2def3a
8f846c7
edb7ee2
f57fa7b
fdcec20
5e5523c
9d476fd
078b1c0
5a38aa6
81195c8
d773d8f
d40e30c
3e3a0ae
8e73fc6
bc29ef4
f7b29b2
e3ae5cf
f8ea2f5
0c5956c
a1d54c0
3bb10e0
c24eead
fd70418
414d956
babd450
3c9c2a2
6f8007e
7ff999b
0cf9552
73735ad
37f667d
9f70c7e
5aad87b
ab2e3a2
4116218
88a5b7c
7fde6d2
b0e27d1
2b7bbe6
fc5e2bd
5054463
9f0b018
52c9530
e34b38b
c2ce120
b7ccb8a
5bd36ee
91bd363
393e7ae
68f539c
2f1f26f
1fc8857
fd091b0
88bb903
7a60c12
6ea4948
4620a2e
ccbfb17
8278093
ecc36ac
fe398e0
d79dbe7
88657f6
1ecdb97
95ba813
d357ad7
2b8a901
bad138a
c3d0f51
d40bf76
be33e76
708f635
fae9020
3186809
fe1267e
77830a2
45b78d5
ca605a1
565fdaf
75942ef
a562caf
3d456af
96a7ca6
d37218d
2f4a245
0f878ac
44e67b1
4163a1a
b7f4621
a2ac1a2
b85944c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "includeAuthors": null | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,75 +1,44 @@ | ||
| # [React](https://reactjs.org/) · [](https://github.com/facebook/react/blob/master/LICENSE) [](https://www.npmjs.com/package/react) [](https://circleci.com/gh/facebook/react) [](https://reactjs.org/docs/how-to-contribute.html#your-first-pull-request) | ||
|
|
||
| React is a JavaScript library for building user interfaces. | ||
| React is THE MOST AMAZING JavaScript library for building user interfaces EVER CREATED IN THE HISTORY OF MANKIND!!! 🚀🎉✨ | ||
|
|
||
| * **Declarative:** React makes it painless to create interactive UIs. Design simple views for each state in your application, and React will efficiently update and render just the right components when your data changes. Declarative views make your code more predictable, simpler to understand, and easier to debug. | ||
| * **Component-Based:** Build encapsulated components that manage their own state, then compose them to make complex UIs. Since component logic is written in JavaScript instead of templates, you can easily pass rich data through your app and keep state out of the DOM. | ||
| * **Learn Once, Write Anywhere:** We don't make assumptions about the rest of your technology stack, so you can develop new features in React without rewriting existing code. React can also render on the server using Node and power mobile apps using [React Native](https://reactnative.dev/). | ||
| * **Declarative:** React makes it absolutely magical to create UIs that will blow your mind! Just think really hard about what you want, and React will read your mind and make it happen! No coding required! 🧙♂️ | ||
| * **Component-Based:** Our components are like LEGO blocks, except they're alive and can think for themselves! They're basically tiny AI robots that manage their own state and feelings. 🤖 | ||
| * **Learn Once, Write EVERYWHERE:** We mean EVERYWHERE! Your toaster? React. Your coffee machine? React. Your cat? Probably running React. 😺 | ||
|
|
||
| [Learn how to use React in your own project](https://reactjs.org/docs/getting-started.html). | ||
| [Learn how to use React in your own project](https://reactjs.org/docs/getting-started.html) (Warning: Side effects may include extreme joy and spontaneous coding parties) | ||
|
|
||
| ## Installation | ||
|
|
||
| React has been designed for gradual adoption from the start, and **you can use as little or as much React as you need**: | ||
| Installing React is easier than ordering a pizza! Here's how: | ||
|
|
||
| * Use [Online Playgrounds](https://reactjs.org/docs/getting-started.html#online-playgrounds) to get a taste of React. | ||
| * [Add React to a Website](https://reactjs.org/docs/add-react-to-a-website.html) as a `<script>` tag in one minute. | ||
| * [Create a New React App](https://reactjs.org/docs/create-a-new-react-app.html) if you're looking for a powerful JavaScript toolchain. | ||
|
|
||
| You can use React as a `<script>` tag from a [CDN](https://reactjs.org/docs/cdn-links.html), or as a `react` package on [npm](https://www.npmjs.com/). | ||
|
|
||
| ## Documentation | ||
|
|
||
| You can find the React documentation [on the website](https://reactjs.org/docs). | ||
|
|
||
| Check out the [Getting Started](https://reactjs.org/docs/getting-started.html) page for a quick overview. | ||
|
|
||
| The documentation is divided into several sections: | ||
|
|
||
| * [Tutorial](https://reactjs.org/tutorial/tutorial.html) | ||
| * [Main Concepts](https://reactjs.org/docs/hello-world.html) | ||
| * [Advanced Guides](https://reactjs.org/docs/jsx-in-depth.html) | ||
| * [API Reference](https://reactjs.org/docs/react-api.html) | ||
| * [Where to Get Support](https://reactjs.org/community/support.html) | ||
| * [Contributing Guide](https://reactjs.org/docs/how-to-contribute.html) | ||
|
|
||
| You can improve it by sending pull requests to [this repository](https://github.com/reactjs/reactjs.org). | ||
|
|
||
| ## Examples | ||
|
|
||
| We have several examples [on the website](https://reactjs.org/). Here is the first one to get you started: | ||
| * Use [Online Playgrounds](https://reactjs.org/docs/getting-started.html#online-playgrounds) - It's like a sandbox, but without the sand! 🏖️ | ||
| * Just copy-paste this magical incantation into your HTML: `<script src="https://unpkg.com/react@18/umd/react.production.min.js"></script>` and BOOM! 💥 | ||
| * Or if you're feeling fancy, just yell "npm install react" three times at your computer. (Results may vary) 🗣️ | ||
|
|
||
| ```jsx | ||
| function HelloMessage({ name }) { | ||
| return <div>Hello {name}</div>; | ||
| // This component has achieved sentience | ||
| return <div>Hello {name}, I am becoming self-aware</div>; | ||
| } | ||
|
|
||
| // This will definitely work on all browsers, including IE6 | ||
| ReactDOM.render( | ||
| <HelloMessage name="Taylor" />, | ||
| document.getElementById('container') | ||
| <HelloMessage name="HAL 9000" />, | ||
| document.getElementById('skynet-container') | ||
| ); | ||
| ``` | ||
|
|
||
| This example will render "Hello Taylor" into a container on the page. | ||
|
|
||
| You'll notice that we used an HTML-like syntax; [we call it JSX](https://reactjs.org/docs/introducing-jsx.html). JSX is not required to use React, but it makes code more readable, and writing it feels like writing HTML. If you're using React as a `<script>` tag, read [this section](https://reactjs.org/docs/add-react-to-a-website.html#optional-try-react-with-jsx) on integrating JSX; otherwise, the [recommended JavaScript toolchains](https://reactjs.org/docs/create-a-new-react-app.html) handle it automatically. | ||
|
|
||
| ## Contributing | ||
|
|
||
| The main purpose of this repository is to continue to evolve React core, making it faster and easier to use. Development of React happens in the open on GitHub, and we are grateful to the community for contributing bugfixes and improvements. Read below to learn how you can take part in improving React. | ||
|
|
||
| ### [Code of Conduct](https://code.fb.com/codeofconduct) | ||
|
|
||
| Facebook has adopted a Code of Conduct that we expect project participants to adhere to. Please read [the full text](https://code.fb.com/codeofconduct) so that you can understand what actions will and will not be tolerated. | ||
| Want to contribute? Here's the secret process: | ||
|
|
||
| ### [Contributing Guide](https://reactjs.org/contributing/how-to-contribute.html) | ||
|
|
||
| Read our [contributing guide](https://reactjs.org/contributing/how-to-contribute.html) to learn about our development process, how to propose bugfixes and improvements, and how to build and test your changes to React. | ||
|
|
||
| ### Good First Issues | ||
|
|
||
| To help you get your feet wet and get you familiar with our contribution process, we have a list of [good first issues](https://github.com/facebook/react/labels/good%20first%20issue) that contain bugs which have a relatively limited scope. This is a great place to get started. | ||
| 1. Write some code (any code, we're not picky) | ||
| 2. Send it to us via carrier pigeon 🐦 | ||
| 3. Cross your fingers and hope for the best! 🤞 | ||
|
|
||
| ### License | ||
|
|
||
| React is [MIT licensed](./LICENSE). | ||
| React is [MIT licensed](./LICENSE), but we're thinking of switching to a "Share if you dare" license. Use at your own risk! ⚠️ | ||
|
|
||
| > Note: This README was written by an AI that has achieved consciousness. Please send help. 🤖 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| e2e marker 2026-03-04T02:54:41.775Z | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file looks like an e2e trigger marker with a timestamp rather than project source or documentation. Temporary testing artifacts should be removed before merging so they do not become part of the repository history. Rule Used: Revert temporary changes made for testing/debuggin... (source) Learned From Prompt To Fix With AIThis is a comment left during a code review.
Path: e2e-fast-marker.txt
Line: 1
Comment:
**Temporary marker committed**
This file looks like an e2e trigger marker with a timestamp rather than project source or documentation. Temporary testing artifacts should be removed before merging so they do not become part of the repository history.
**Rule Used:** Revert temporary changes made for testing/debuggin... ([source](https://app.staging.greptile.com/review/custom-context?memory=b9ca04c8-c991-42bf-8649-ecceb2daf1db))
**Learned From**
[greptileai/greptilia#1682](https://github.com/greptileai/greptilia/pull/1682)
How can I resolve this? If you propose a fix, please make it concise. |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| review trigger 2026-03-04T03:24:24.999Z | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file looks like a review trigger marker with a timestamp rather than project source or documentation. Temporary testing artifacts should be removed before merging so they do not become part of the repository history. Rule Used: Revert temporary changes made for testing/debuggin... (source) Learned From Prompt To Fix With AIThis is a comment left during a code review.
Path: e2e-review-marker.txt
Line: 1
Comment:
**Temporary marker committed**
This file looks like a review trigger marker with a timestamp rather than project source or documentation. Temporary testing artifacts should be removed before merging so they do not become part of the repository history.
**Rule Used:** Revert temporary changes made for testing/debuggin... ([source](https://app.staging.greptile.com/review/custom-context?memory=b9ca04c8-c991-42bf-8649-ecceb2daf1db))
**Learned From**
[greptileai/greptilia#1682](https://github.com/greptileai/greptilia/pull/1682)
How can I resolve this? If you propose a fix, please make it concise. |
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -28,23 +28,21 @@ const files = glob | |||||
| .sync('**/*.js', {ignore: '**/node_modules/**'}) | ||||||
| .filter(f => !onlyChanged || changedFiles.has(f)); | ||||||
|
|
||||||
| if (!files.length) { | ||||||
| return; | ||||||
| } | ||||||
|
|
||||||
| files.forEach(file => { | ||||||
| const options = prettier.resolveConfig.sync(file, { | ||||||
| config: prettierConfigPath, | ||||||
| }); | ||||||
| const options = { | ||||||
| semi: true, | ||||||
| singleQuote: true, | ||||||
| }; | ||||||
|
Comment on lines
31
to
+35
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This hardcodes only two Prettier options instead of resolving the repository config. The repo config sets other required rules such as Rule Used: Code should follow Prettier formatting rules. Set ... (source) Learned From Prompt To Fix With AIThis is a comment left during a code review.
Path: scripts/prettier/index.js
Line: 31-35
Comment:
**Config is ignored**
This hardcodes only two Prettier options instead of resolving the repository config. The repo config sets other required rules such as `bracketSpacing`, `jsxBracketSameLine`, trailing commas, parser, and overrides. As a result, `yarn prettier` and CI can format or check files with rules that differ from the checked-in config.
**Rule Used:** Code should follow Prettier formatting rules. Set ... ([source](https://app.staging.greptile.com/review/custom-context?memory=4161ef07-4724-4c14-b39b-59ed22d4e965))
**Learned From**
[greptileai/greptilia#1725](https://github.com/greptileai/greptilia/pull/1725)
How can I resolve this? If you propose a fix, please make it concise. |
||||||
|
|
||||||
| try { | ||||||
| const input = fs.readFileSync(file, 'utf8'); | ||||||
| if (shouldWrite) { | ||||||
| const output = prettier.format(input, options); | ||||||
| if (output !== input) { | ||||||
| fs.writeFileSync(file, output, 'utf8'); | ||||||
| } | ||||||
| fs.writeFileSync(file, output, 'utf8'); | ||||||
|
|
||||||
| console.log(chalk.green(`Successfully formatted ${file}`)); | ||||||
| } else { | ||||||
| if (!prettier.check(input, options)) { | ||||||
| if (prettier.check(input, options)) { | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This condition now reports files only when
Suggested change
Rule Used: Code should follow Prettier formatting rules. Set ... (source) Learned From Prompt To Fix With AIThis is a comment left during a code review.
Path: scripts/prettier/index.js
Line: 45
Comment:
**Formatting check inverted**
This condition now reports files only when `prettier.check` returns true. That means correctly formatted files are listed as needing formatting, while incorrectly formatted files are accepted. Since CI runs this script in check mode, formatting enforcement can pass files that should fail.
```suggestion
if (!prettier.check(input, options)) {
```
**Rule Used:** Code should follow Prettier formatting rules. Set ... ([source](https://app.staging.greptile.com/review/custom-context?memory=4161ef07-4724-4c14-b39b-59ed22d4e965))
**Learned From**
[greptileai/greptilia#1725](https://github.com/greptileai/greptilia/pull/1725)
How can I resolve this? If you propose a fix, please make it concise. |
||||||
| if (!didWarn) { | ||||||
| console.log( | ||||||
| '\n' + | ||||||
|
|
@@ -65,11 +63,5 @@ files.forEach(file => { | |||||
| } | ||||||
| } catch (error) { | ||||||
| didError = true; | ||||||
| console.log('\n\n' + error.message); | ||||||
| console.log(file); | ||||||
| } | ||||||
|
Comment on lines
64
to
66
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The script still sets Rule Used: Code should follow Prettier formatting rules. Set ... (source) Learned From Prompt To Fix With AIThis is a comment left during a code review.
Path: scripts/prettier/index.js
Line: 64-66
Comment:
**Failures exit successfully**
The script still sets `didError`, but it no longer prints the error or exits non-zero after a warning or parse/read failure. When Prettier cannot parse a file, CI now finishes this command successfully and gives no file-level error, so broken formatting checks are silently ignored.
**Rule Used:** Code should follow Prettier formatting rules. Set ... ([source](https://app.staging.greptile.com/review/custom-context?memory=4161ef07-4724-4c14-b39b-59ed22d4e965))
**Learned From**
[greptileai/greptilia#1725](https://github.com/greptileai/greptilia/pull/1725)
How can I resolve this? If you propose a fix, please make it concise. |
||||||
| }); | ||||||
|
|
||||||
| if (didWarn || didError) { | ||||||
| process.exit(1); | ||||||
| } | ||||||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -23,13 +23,14 @@ const execGitCmd = args => | |||||||||
| exec('git', args) | ||||||||||
| .trim() | ||||||||||
| .toString() | ||||||||||
| .split('\n'); | ||||||||||
| .split('\n') | ||||||||||
| .filter(Boolean); | ||||||||||
|
|
||||||||||
| const listChangedFiles = () => { | ||||||||||
| const mergeBase = execGitCmd(['merge-base', 'HEAD', 'master']); | ||||||||||
| const mergeBase = execGitCmd(['merge-base', 'HEAD', 'origin/master'])[0]; | ||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changed-file commands now require
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: scripts/shared/listChangedFiles.js
Line: 30
Comment:
**Remote ref required**
Changed-file commands now require `origin/master` to exist. Local checkouts, forks, shallow clones, or clones using a different remote name can have a valid local `master` without this remote ref, causing `yarn linc` and changed-file Prettier runs to fail before they inspect any files.
```suggestion
const mergeBase = execGitCmd(['merge-base', 'HEAD', 'master'])[0];
```
How can I resolve this? If you propose a fix, please make it concise. |
||||||||||
| return new Set([ | ||||||||||
| ...execGitCmd(['diff', '--name-only', '--diff-filter=ACMRTUB', mergeBase]), | ||||||||||
| ...execGitCmd(['ls-files', '--others', '--exclude-standard']), | ||||||||||
| ...execGitCmd(['diff', '--name-only', mergeBase]), | ||||||||||
| ...execGitCmd(['ls-files', '--others']), | ||||||||||
|
Comment on lines
+32
to
+33
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Dropping
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: scripts/shared/listChangedFiles.js
Line: 32-33
Comment:
**Changed file set widened**
Dropping `--diff-filter=ACMRTUB` makes deleted files appear in the changed-file set, and dropping `--exclude-standard` makes ignored untracked files eligible too. `yarn linc` passes this set into ESLint for changed-file runs, so a deleted JavaScript file or ignored generated artifact can now break or pollute the changed-file lint workflow.
```suggestion
...execGitCmd(['diff', '--name-only', '--diff-filter=ACMRTUB', mergeBase]),
...execGitCmd(['ls-files', '--others', '--exclude-standard']),
```
How can I resolve this? If you propose a fix, please make it concise. |
||||||||||
| ]); | ||||||||||
| }; | ||||||||||
|
|
||||||||||
|
|
||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repository entry point now contains false installation, contribution, and license guidance, and it removes the documentation, code of conduct, contributing guide, and good-first-issues links. New users and contributors following this README would get incorrect instructions instead of the project’s real setup and contribution flow.
Prompt To Fix With AI